Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the method _maybe_format_datakeys_with_stream_name into a method for each of its use cases #1688

Open
abbiemery opened this issue Apr 9, 2024 · 1 comment · May be fixed by #1711
Assignees
Labels
hackathon Good issues for the upcoming bluesky hackathon

Comments

@abbiemery
Copy link
Contributor

Recently the collect method in the run blundler was refactored to reduce mixing of code paths. Previously _maybe_format_datakeys_with_stream_name would take one of two different data structures layouts (a new and an older) and would format it respectively to it's type. Now these two paths have been separated so that _maybe_format_datakeys_with_stream_name is called with one structure type in declare_stream, and with a different in _describe_collect. Instead of having one method for both it would be worth doing these seperately.

@abbiemery abbiemery added the hackathon Good issues for the upcoming bluesky hackathon label Apr 9, 2024
@callumforrester
Copy link
Contributor

callumforrester commented Apr 15, 2024

Reviewers: @abbiemery @genematx

@DiamondJoseph DiamondJoseph linked a pull request Apr 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Good issues for the upcoming bluesky hackathon
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants