Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Plans to Handle FailedPause #1691

Open
callumforrester opened this issue Apr 11, 2024 · 0 comments
Open

Allow Plans to Handle FailedPause #1691

callumforrester opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
hackathon Good issues for the upcoming bluesky hackathon

Comments

@callumforrester
Copy link
Contributor

callumforrester commented Apr 11, 2024

The RunEngine can be paused mid-execution of a plan. It will ask the ophyd(-async) devices it is currently using to .pause() if they are Pausable. They may throw a FailedPause exception if anything goes wrong. The RunEngine does not currently handle this behaviour very well, it just stops abruptly and raises an exception.

Desired Behaviour

When a device fails to pause, the RunEngine should effectively cancel the pause and keep going. The user should be altered to what happened via a warning or sensible exception.

Possible Solution

@tacaswell started a WIP PR to handle this: #1634, so acceptance criteria for this issue is that PR is finished off and merged. See PR discussion for remaining work to be done.

@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Good issues for the upcoming bluesky hackathon
Projects
Status: In Progress
Development

No branches or pull requests

2 participants