Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 and 3.12 #1670

Open
callumforrester opened this issue Mar 25, 2024 · 9 comments
Open

Support Python 3.11 and 3.12 #1670

callumforrester opened this issue Mar 25, 2024 · 9 comments

Comments

@callumforrester
Copy link
Contributor

Expected Behavior

Tests should pass for supported Python versions >=3.9

Current Behavior

Tests currently fail for Python >3.10

Context

Suggested by @mrakitin in #1664

@tacaswell
Copy link
Contributor

With #1672 the tests pass locally for me with the CPython 3.12 branch.

@tacaswell
Copy link
Contributor

Although if I run pytest with warnings as errors I get a bunch of .... interesting..... related failures due to not handleing exceptions an background threads.

@callumforrester
Copy link
Contributor Author

Interesting, I'm seeing the following for 3.12:

FAILED bluesky/tests/test_utils.py::test_CallbackRegistry_1[class_method-False-True] - AssertionError: Incorrect number of signals

@tacaswell
Copy link
Contributor

Interesting, in #1672 the py311 and py312 are passing, but the older ones are failing.

I never saw that failure locally...

@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 8, 2024
@callumforrester
Copy link
Contributor Author

@tacaswell Is there any policy on deprecation? Numpy hasn't supported 3.8 for almost a year: https://endoflife.date/numpy, perhaps we should drop it

@tacaswell
Copy link
Contributor

We should follow https://numpy.org/neps/nep-0029-deprecation_policy.html / https://scientific-python.org/specs/spec-0000/ as closely as we can without causing critical operational problems for any of the facilities who are actively involved in the collaboration.

I'm not sure if we have that formalized anyplace though.

@prjemian
Copy link
Contributor

prjemian commented Apr 8, 2024

Why doesn't numpy follow the Python supported versions schedule? Py3.8 is not yet EOL (happens later this year).

@tacaswell
Copy link
Contributor

@prjemian read the NEP29 on SPEC0 text for the long answer. The short answer is we decided to support a slightly shorter time window of versions than "all versions of Python that are still getting security bug-fixes" upstream.

@callumforrester callumforrester removed the hackathon Good issues for the upcoming bluesky hackathon label Apr 9, 2024
@callumforrester
Copy link
Contributor Author

Done now #1672 is merged, will make another ticket for dropping 3.8 and 3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants