Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 2.4: "Recent Connections" is empty #2328

Open
1 task done
fbuetler opened this issue Apr 4, 2024 · 7 comments
Open
1 task done

Regression 2.4: "Recent Connections" is empty #2328

fbuetler opened this issue Apr 4, 2024 · 7 comments

Comments

@fbuetler
Copy link

fbuetler commented Apr 4, 2024

blueman: 2.4-1
BlueZ: 5.73-4
Distribution: arch
Desktop environment: wayland

Updating from 2.3 to 2.4 introduced a regression having an empty list in the "Recent Connection" tab in the applet. Downgrading to 2.3 showed them again:

2.3:
bm-2 3 5

2.4:
bm-2 4 0

Either this or the idea was to remove "Recent Connections" completely as all audio profiles are now inlined?

@cschramm
Copy link
Member

cschramm commented Apr 4, 2024

Not sure I can follow. Aren't the items that you blurred your recent connections?

@fbuetler
Copy link
Author

fbuetler commented Apr 4, 2024

Thanks for the quick reply.

Yes, this possibility is reflected in my last comment

Either this or the idea was to remove "Recent Connections" completely as all audio profiles are now inlined?

Maybe it is just me not understanding the new UI correctly. For me, the Audio and input profile on ... look more like configuration options to me. But indeed, clicking on an element there connects the device.

The main confusion comes from the fact, that in prior versions one had to click on the "Recent Connections" element to connect to a recent device and in 2.4 the element is still there, but its function is now a title (it's also the only title in this menu).

Maybe this can be reconsidered?

Changing Audio and input profile on <device> to Connect to <device> might be a possibility.

Relevant code:

@cschramm
Copy link
Member

cschramm commented Apr 4, 2024

We moved the recent connections from the submenu into the toplevel applet menu and "Recent Connections" is a title to give them some context, yes. #1558 / #1652

Prefixing the items with "Connect to..." makes sense, I guess. We could also rename the title to that or "Reconnect to...".

@fbuetler
Copy link
Author

fbuetler commented Apr 4, 2024

I see you oriented yourself on the nm-applet as they are using similar title styles. In this case, completely dropping the prefix Audio and input profile on might be the slimmest solution, like nm-applet is doing with networks (this makes it even easier as there are no new translations to be added).

@cschramm
Copy link
Member

cschramm commented Apr 4, 2024

That's not really an option. E.g. for a phone you typically can have entries like:

  • Auto-connect profiles (audio and input)
  • Some network profile
  • Some serial profile

The auto-connect item will not connect any network or serial profile and vice-versa.

@kuraga
Copy link
Contributor

kuraga commented Apr 5, 2024

Changing Audio and input profile on <device> to Connect to <device> might be a possibility.

Came there from another side at #2319 (comment).

@cschramm
Copy link
Member

cschramm commented Apr 9, 2024

Not sure what to do here. I think the main point (ignoring any confusion caused by the change itself if you are used to the old menu) is that the "{services} on {device}" items do not immediately tell you that they are about using a recent connection and it does not seem clear from the title and "grouping". Adding "Connect to" to each item would perfectly fix that but be rather bulky. I'd rather try to find a better title like "Reconnect to..." (including the ellipsis in hope that it also makes it more obvious that it's a titel for the following items).

cschramm added a commit to cschramm/blueman that referenced this issue May 10, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4.

Closes blueman-project#2328
infirit pushed a commit to cschramm/blueman that referenced this issue May 15, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4.

Closes blueman-project#2328
cschramm added a commit that referenced this issue May 15, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4.

Closes #2328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants