Only show a singly battery notifcation #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From feedback in blueman-project#2317 it became pretty clear that battery data is a mess with devices providing levels like full, medium, low and devices providing fine-grained percent values, flapping values etc. and we do not want to go into power management applet business, so we only show a single battery connection (when the battery interface shows up or - if the interface is already present when the device connects - when the existing interface sends its first property update) and drop the reference to the connection notification to update so that further values do not lead to a notification. (In case people will ask for those notifications we might add them as a separate plugin that's disabled by default.) Due to the great demand, I plan to backport this for 2.4.2, even though it's technically a regression. Closes blueman-project#2317
|
1 task
ouuan
approved these changes
May 10, 2024
cschramm
added a commit
to cschramm/blueman
that referenced
this pull request
May 10, 2024
Backport of blueman-project#2362 due to the great demand seen in blueman-project#2317. This is technically a regression, but the current behavior seems unacceptable in many cases, so let's pretend that we never intentionally added those additional notifications. Closes blueman-project#2317
infirit
approved these changes
May 15, 2024
infirit
pushed a commit
to cschramm/blueman
that referenced
this pull request
May 15, 2024
Backport of blueman-project#2362 due to the great demand seen in blueman-project#2317. This is technically a regression, but the current behavior seems unacceptable in many cases, so let's pretend that we never intentionally added those additional notifications. Closes blueman-project#2317
infirit
pushed a commit
to cschramm/blueman
that referenced
this pull request
May 15, 2024
Backport of blueman-project#2362 due to the great demand seen in blueman-project#2317. This is technically a regression, but the current behavior seems unacceptable in many cases, so let's pretend that we never intentionally added those additional notifications. Closes blueman-project#2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From feedback in #2317 it became pretty clear that battery data is a mess with devices providing levels like full, medium, low and devices providing fine-grained percent values, flapping values etc. and we do not want to go into power management applet business, so we only show a single battery notification on connection (when the battery interface shows up or - if the interface is already present when the device connects - when the existing interface sends its first property update) and drop the reference to the connection notification to update so that further values do not lead to a notification. (In case people will ask for those notifications we might add them as a separate plugin that's disabled by default.)
Due to the great demand, I plan to backport this for 2.4.2, even though it's technically a regression.
Closes #2317