Full color icons missing in default icon theme #2312

nebulosa2007 · 2024-04-01T16:57:37Z

blueman: 2.4
BlueZ: 5.73-4
Distribution: Arch Linux
Desktop environment: Niri (wayland)

[ x ] I have consulted the Troubleshooting page and done my best effort to follow.

After upgrading to version 2.4, my Bluetooth speaker is not listed, but I can interact with it. When left-clicking, a drop-down menu appears (e.g. "Rename" is selected ):

Log from the terminal (it adds more lines on hovering over the selected line). The Trust item also doesn't work (last 15 lines)

The text was updated successfully, but these errors were encountered:

cschramm · 2024-04-01T19:54:28Z

The crucial issue is Icon 'audio-card' not present in theme Adwaita. As audio-card definitely is part of the
Adwaita Icon Theme, you seem to have an issue with your installed and active theme. In #2101 (comment) just switching themes forth and back did the trick to fix it. 🤷

infirit · 2024-04-02T09:31:39Z

The fallback I added for this is broken. Blueman now skips making an IconInfo object which would return None instead of raising GEerror.

nebulosa2007 · 2024-04-02T11:04:29Z

In #2101 (comment) just switching themes forth and back did the trick to fix it. 🤷

I don't know how it can do this, I haven't gnome environment or Gnome setting apps..

Btw, after installing gnome-icon-theme package all the errors disappeared. I think this is an obsolete package in Arch, so I need other thoughts, If any.

adwaita-icon-theme package is already installed as a dependency of gtk3 and gtk4

cschramm · 2024-04-02T11:42:01Z

In #2101 (comment) just switching themes forth and back did the trick to fix it. 🤷

I don't know how it can do this, I haven't gnome environment or Gnome setting apps..

If there's no specific support for it, editing $HOME/.config/gtk-3.0/settings.ini should do the trick, possibly combined with some kind of reload, but read on...

Btw, after installing gnome-icon-theme package all the errors disappeared. I think this is an obsolete package in Arch, so I need other thoughts, If any.

They came back when uninstalling, I suppose?

adwaita-icon-theme package is already installed as a dependency of gtk3 and gtk4

Exactly. It's a vital part of GTK as it ships defaults that all themes fall back to. That's why there is no good reason for audio-card to be unavailable.

My first guess would be some kind of broken cache. I'd try gtk-update-icon-cache (and probably switching icon themes forth and back has exactly that effect).

Another option could be a broken icon theme, that actually breaks the fallbacks. Not sure if that's possible.

nebulosa2007 · 2024-04-02T13:54:56Z

If there's no specific support for it, editing $HOME/.config/gtk-3.0/settings.ini should do the trick, possibly combined with some kind of reload, but read on...

I don't have files ..../gtk-3.0/settings.ini or ..../gtk-4.0/settings.ini

They came back when uninstalling, I suppose?

Yes, exactly.

My first guess would be some kind of broken cache. I'd try gtk-update-icon-cache (and probably switching icon themes forth and back has exactly that effect).
Another option could be a broken icon theme, that actually breaks the fallbacks. Not sure if that's possible.

$ ls -1d /usr/share/icons/* | tee /dev/tty | xargs -I {} sudo gtk-update-icon-cache -f {}
/usr/share/icons/Adwaita/
/usr/share/icons/default/
/usr/share/icons/hicolor/
gtk-update-icon-cache: Cache file created successfully.
gtk-update-icon-cache: Cache file created successfully.

Didn't help again.

So it's just a distribution issue on Arch?

cschramm · 2024-04-02T14:19:55Z

A simple test for a python shell:

import gi
gi.require_version("Gtk", "3.0")
from gi.repository import Gtk
Gtk.IconTheme.get_default().load_surface("audio-card", 48, 1, None, Gtk.IconLookupFlags.FORCE_SIZE)

This is basically what blueman does, except that it gets the scale factor from GTK, so that it could be something else than 1 (typically 2) and it passes a window.

I expect this to always work as Adwaita ships a scalable audio-card icon with specified sizes between 8 and 512.

Just to double check: /usr/share/icons/default/ simply has an index.theme with the following, correct?

[Icon Theme]
Inherits=Adwaita

nebulosa2007 · 2024-04-02T14:26:42Z

Yes:

$ cat /usr/share/icons/default/index.theme 
[Icon Theme]
Inherits=Adwaita

And test output is:

$ python test.py 
Traceback (most recent call last):
  File "/home/nebulosa/test.py", line 4, in <module>
    Gtk.IconTheme.get_default().load_surface("audio-card", 48, 1, None, Gtk.IconLookupFlags.FORCE_SIZE)
gi.repository.GLib.GError: gtk-icon-theme-error-quark: Icon 'audio-card' not present in theme Adwaita (0)

cschramm · 2024-04-02T14:41:37Z

Might be best to file a bug with the adwaita-icon-theme Arch package to get behind that. From my understanding, there is no way for it to not provide the icon. The path is basically: Directories in /usr/share/icons/Adwaita/index.theme containing symbolic/devices and a respective section:

[symbolic/devices]
Context=Devices
Size=16
MinSize=8
MaxSize=512
Type=Scalable

=> /usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg gets used for sizes of 8 to 512.

nebulosa2007 · 2024-04-02T14:59:26Z

$ grep -A5 "\[symbolic/devices\]" /usr/share/icons/Adwaita/index.theme
[symbolic/devices]
Context=Devices
Size=16
MinSize=8
MaxSize=512
Type=Scalable

$ file /usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg
/usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg: SVG Scalable Vector Graphics image

I'll make an issue on a Archlinux bugtracker then.

edit: issue on Archlinux bug tracker

infirit · 2024-04-02T18:51:09Z

The fallback I added for this is broken. Blueman now skips making an IconInfo object which would return None instead of raising GEerror.

#2316 fixes the fallback for broken icon themes.

nebulosa2007 · 2024-04-03T08:00:11Z

New info! After link file (or copy) and update icons cache all errors are gone:

$ sudo ln -s /usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg /usr/share/icons/Adwaita/symbolic/devices/audio-card.svg 

$ ls -1d /usr/share/icons/* | tee /dev/tty | xargs -I {} sudo gtk-update-icon-cache -f {}
/usr/share/icons/Adwaita/
/usr/share/icons/default/
/usr/share/icons/hicolor/
gtk-update-icon-cache: Cache file created successfully.
gtk-update-icon-cache: Cache file created successfully.

Btw, this icon is different than above.

I think that blueman looking for exactly audio-card.* but not audio-card<whatever>.* file and take the biggest one as possible. I found icon from previous screenshot here /usr/share/icons/gnome/48x48/devices/audio-card.png

This icons also can be fixed by changing filenames I suppose..

cschramm · 2024-04-03T09:31:41Z

I'm totally confused, but, yes, the symbolic version is the only one in the package and it does not seem to get used unless requested explicitly (by name or with Gtk.IconLookupFlags.FORCE_SYMBOLIC). It looks like adwaita-icon-theme 44 dropped non-symbolic icons, not even reflecting that in the changelog.

infirit · 2024-04-03T11:59:27Z

There are a bunch of issues on the adwaita icon theme gitlab about full corour icons that got dropped the 44 release. The issues I checked were fixed by re-adding them.

cschramm · 2024-04-03T12:23:10Z

Only very few of the icons I listed in #976 (comment) are still available as non-symbolic, namely computer, image-missing, input-*, network-workgroup, phone and printer. Wtf... 😕

infirit · 2024-04-03T20:01:29Z

I took your list and checked which one I had on my system.

Missing

audio-card
camera-photo
camera-video
modem
network-wireless

In scalable directory

computer
input-gaming
input-keyboard
input-mouse
input-tablet
phone
printer

I don't use Adwaita as icon theme so I never noticed them missing.

cschramm · 2024-04-05T08:11:36Z

That's just one part of the list, namely names provided by BlueZ. Of all the other icons that we use image-missing and network-workgroup are the only ones still available.

cschramm · 2024-04-05T08:16:33Z

Still unsure where to go from here. One obvious solution would be to always use symbolic icons for everything...

I plan to a add a note on icon themes to the release description on GitHub. Something like: Note to maintainers: We found that the Adwaita Icon Theme dropped most non-symbolic icons in version 44, so that it can no longer be considered a generic fallback for GTK. blueman with just Adwaita Icon Theme will show a lot of missing icons. We are still puzzled by this change and try to figure out what to do. You can jump in at #2312. In the meantime, make sure that your packages depend on proper icons themes.

I plan to a add a note on icon themes to the release description on GitHub. Something like: Note to maintainers: We found that the Adwaita Icon Theme dropped most non-symbolic icons in version 44, so that it can no longer be considered a generic fallback for GTK. blueman with just Adwaita Icon Theme will show a lot of missing icons. We are still puzzled by this change and try to figure out what to do. You can jump in at blueman-project#2312. In the meantime, make sure that your packages depend on proper icons themes.

cschramm · 2024-04-05T09:54:09Z

Oh, forget what I wrote. We're already using symbolic icons in many places anyway. Is this actually just an issue with BlueZ-provided device icons? 🤔 Would be easy to force symbolic ones there of course.

Edit: It's not. We e.g. use dialog-error.

Quick experiment in #2330

nebulosa2007 · 2024-04-05T15:07:42Z

Let's try!

# Check files:
$ file /usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg
/usr/share/icons/Adwaita/symbolic/devices/audio-card-symbolic.svg: SVG Scalable Vector Graphics image
$ file  /usr/share/icons/Adwaita/symbolic/devices/audio-card.svg
/usr/share/icons/Adwaita/symbolic/devices/audio-card.svg:          cannot open `/usr/share/icons/Adwaita/symbolic/devices/audio-card.svg' (No such file or directory)

Built and installed packages with patches, here are the results:
2.4 + #2316:

2.4 + #2330:

2.4 + #2316 + #2330:

But those icons are still broken:

Edit: After reboot (?) icons got back. So for me, it seems, that issue can be closed. All icons got back

cschramm · 2024-04-05T21:07:17Z

But those icons are still broken:

I don't get what you mean there.

Edit: After reboot (?) icons got back. So for me, it seems, that issue can be closed. All icons got back

You're not saying you have device icons without any patches now, are you? 😅

nebulosa2007 · 2024-04-06T06:19:56Z

I don't get what you mean there.

Never mind. Icons (orange and blue) appears when device is connected. Didn't notice it before.

You're not saying you have device icons without any patches now, are you? 😅

Nope. Device icons appear when I apply the #2330 patch (with or without patch #2316) and build the package afterwards. For now I will wait for upstream updates and use the patched version.

P.S.
Not only blueman has this issue, I checked also pavucontrol and found the rabbit hole

infirit · 2024-04-06T09:30:36Z

Typical gnome behaviour. Looks like we need resurrect our old icons or find a new set.

I plan to a add a note on icon themes to the release description on GitHub. Something like: Note to maintainers: We found that the Adwaita Icon Theme dropped most non-symbolic icons in version 44, so that it can no longer be considered a generic fallback for GTK. blueman with just Adwaita Icon Theme will show a lot of missing icons. We are still puzzled by this change and try to figure out what to do. You can jump in at blueman-project#2312. In the meantime, make sure that your packages depend on proper icons themes.

cschramm · 2024-04-08T17:15:45Z

I fail to find a proper primary source, but at least https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/242 makes it very clear that

a-i-t is no longer some icon and cursor pack for everyone to use and apps should bundle their own icons

Unfortunately that effectively means that there just is no "icon pack for everyone to use", it seems. Wow, what a mess... 😒

Well, we can just choose an icon theme that we like and that fits our license (fingers crossed 🤞 😅) and bundle their icons. Most desktops will override them anyway and maintainers could strip them from their blueman packages (I do not really see how they set their packages up then, though, as they'd have to scan all their distribution's icon themes for compatibility to indicate that any of the compatible ones is a dependency of blueman).

To put it more precisely: Wow, what a ridiculous mess for the whole Linux desktop!

infirit · 2024-04-08T20:21:24Z

We can add additional search paths to the Gtk.IconTheme and point it to fallback icons we provide in some directory we control. Something like /usr/share/blueman/icons. I kinda hope distributions will drop Adwaita as the default and use something that provides full color icons following the icon naming spec.

edit: I updates the description.

I plan to a add a note on icon themes to the release description on GitHub. Something like: Note to maintainers: We found that the Adwaita Icon Theme dropped most non-symbolic icons in version 44, so that it can no longer be considered a generic fallback for GTK. blueman with just Adwaita Icon Theme will show a lot of missing icons. We are still puzzled by this change and try to figure out what to do. You can jump in at #2312. In the meantime, make sure that your packages depend on proper icons themes.

nebulosa2007 · 2024-04-09T10:30:08Z

In the meantime, make sure that your packages depend on proper icons themes.

Arch Linux has no default icon themes, only those provided by program developers. That's how I discovered this bug. If it will be just symbolic icons that's will be fine I guess.

infirit · 2024-04-09T12:22:53Z

They have to and do. The content of the file you checked before (below) can't inherit from Adwaita anymore. So whatever this is set to has to provide a full icon theme that applications should be able to rely on.

$ cat /usr/share/icons/default/index.theme 
[Icon Theme]
Inherits=Adwaita

infirit · 2024-05-04T10:48:25Z

By now budgie, cinnamon and plasma have blacklisted adwaita in their system settings ui as it is no longer an fdo compatible icon theme.

My suggestion is we also enforce at lesst one compatibe theme at build time. Breeze can be added to the list as it has everything we need.

cschramm · 2024-05-10T11:26:35Z

Breeze can be added to the list as it has everything we need.

Does it? Querying just a few icon names from our code, it does not seem to have e.g. application-x-addon-symbolic, modem-symbolic, or gnome-power-manager-symbolic and we cannot assume a fallback on Adwaita for them, can we?

Papirus looks pretty complete from a quick glance.

Even worse than finding compatible themes, MATE's and Linux Mint's seem incompatible as well, they e.g. lack application-x-addon-symbolic.

clefebvre · 2024-05-10T15:14:24Z

Hi @cschramm and @infirit,

Are you on Matrix or IRC? I'd love to help and get your feedback on this. It's affecting a lot of people and projects right now, DEs, distros, apps :)

infirit · 2024-05-10T20:48:07Z

I'm on neither @clefebvre. The best place to get the latest on this is this issue created by Nate Graham from KDE, https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288.

Specifically this comment from the AIT maintainer is a reasonable solution.

However AIT as of commit https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/commit/788c7a2c0ff0b95d540148715c7cee612e9404f8 has a fallback to Tango. That would probably be the best short term solution.

edit: tango looks very dated though so maybe not 🤷

cschramm · 2024-05-11T07:43:04Z

I don't find e.g. modem in Tango, but https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/merge_requests/70 looks promising. Ideally AdwaitaLegacy would have scalables, but at least it should make Adwaita provide everything that we use again.

clefebvre · 2024-05-11T10:15:55Z

Tango isn't maintained anymore :(

There's also an issue coming from the fact that Adwaita provides symbolics and fullcolors come from GNOME. The two-level inheritance leads to Adwaita symbolics taking priority over inherited Fullcolor.

clefebvre · 2024-05-11T11:02:34Z

https://gitlab.gnome.org/jimmac/adwaita-icon-theme-legacy/ looks good indeed. I'll try and talk with Jakub about the symbolic inheritance.

The situation is definitely going to get fixed somehow and no matter what, individual apps won't need to adapt. This is something toolkits/DEs/distros need to guarantee to app developers.

nebulosa2007 · 2024-05-30T09:14:19Z

Seems that Issue is resolved - now all icons in apps is showed. If not, package maintainers should add adwaita-icon-theme-legacy dependency

Now blueman looks like this - #2312 (comment)

cschramm · 2024-05-30T21:43:02Z

Awesome! The recently released Adwaita Icon Theme 46.2 added the inheritance from Adwaita Icon Theme legacy, so anybody experiencing this just needs to update to get icons back. 🎉

nebulosa2007 changed the title ~~Device not shown (text doesn't appear) in devices list but it work~~ Device not shown (text doesn't appear) in devices list Apr 1, 2024

infirit self-assigned this Apr 2, 2024

cschramm mentioned this issue Apr 5, 2024

Prepare 2.4.1 #2329

Merged

infirit removed their assignment Apr 9, 2024

infirit changed the title ~~Device not shown (text doesn't appear) in devices list~~ Full color icons missing in default icon theme Apr 9, 2024

cschramm modified the milestones: 2.4.2, 2.5 Apr 10, 2024

clefebvre mentioned this issue May 10, 2024

Desktop entry referrences non-existent icon linuxmint/nemo#3386

Open

nebulosa2007 closed this as completed May 30, 2024

Full color icons missing in default icon theme #2312

Full color icons missing in default icon theme #2312

Comments

nebulosa2007 commented Apr 1, 2024

cschramm commented Apr 1, 2024

infirit commented Apr 2, 2024

nebulosa2007 commented Apr 2, 2024

cschramm commented Apr 2, 2024

nebulosa2007 commented Apr 2, 2024

cschramm commented Apr 2, 2024

nebulosa2007 commented Apr 2, 2024

cschramm commented Apr 2, 2024

nebulosa2007 commented Apr 2, 2024 • edited

infirit commented Apr 2, 2024

nebulosa2007 commented Apr 3, 2024 • edited

cschramm commented Apr 3, 2024

infirit commented Apr 3, 2024

cschramm commented Apr 3, 2024

infirit commented Apr 3, 2024

cschramm commented Apr 5, 2024

cschramm commented Apr 5, 2024

cschramm commented Apr 5, 2024 • edited

nebulosa2007 commented Apr 5, 2024 • edited

cschramm commented Apr 5, 2024

nebulosa2007 commented Apr 6, 2024

infirit commented Apr 6, 2024

cschramm commented Apr 8, 2024

infirit commented Apr 8, 2024 • edited

nebulosa2007 commented Apr 9, 2024 • edited

infirit commented Apr 9, 2024

infirit commented May 4, 2024

cschramm commented May 10, 2024

clefebvre commented May 10, 2024

infirit commented May 10, 2024 • edited

cschramm commented May 11, 2024

clefebvre commented May 11, 2024

clefebvre commented May 11, 2024

nebulosa2007 commented May 30, 2024

cschramm commented May 30, 2024

nebulosa2007 commented Apr 2, 2024 •

edited

nebulosa2007 commented Apr 3, 2024 •

edited

cschramm commented Apr 5, 2024 •

edited

nebulosa2007 commented Apr 5, 2024 •

edited

infirit commented Apr 8, 2024 •

edited

nebulosa2007 commented Apr 9, 2024 •

edited

infirit commented May 10, 2024 •

edited