Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add necessary conditional compilation cfgs #1752

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Add necessary conditional compilation cfgs #1752

merged 2 commits into from
Aug 3, 2022

Conversation

trevor-crypto
Copy link
Contributor

This will allow for building on non windows or unix platforms

@trevor-crypto
Add necessary condition compilation cfgs
9a27502 
This will allow for building on non windows or unix platforms
djc
djc reviewed Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. Are you interested in a specific platform (is it WASM)?

crates/resolver/src/hosts.rs Show resolved Hide resolved
crates/resolver/src/hosts.rs Outdated Show resolved Hide resolved
@trevor-crypto
Copy link
Contributor Author

is it WASM

@djc no, it is Intel SGX (target_env = "sgx"), but it turns out I don't get much use of the Resolver since it requires tokio. I thought that I should raise the PR anyway since it allows for a successful build when not(any(unix, windows)))

@trevor-crypto trevor-crypto changed the title Add necessary condition compilation cfgs Add necessary conditional compilation cfgs Aug 2, 2022
bluejekyll
bluejekyll approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the PR. @djc, since you were reviewing this I'll let you merge to make sure everything you might have been concerned with is taken care of.

@djc djc merged commit be6d6a6 into hickory-dns:main Aug 3, 2022
@djc
Copy link
Collaborator

djc commented Aug 3, 2022

Yup, everything looking good. Thanks!

@trevor-crypto trevor-crypto deleted the resolver-hosts-fix branch August 3, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trevor-crypto @djc @bluejekyll