Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup access Records list directly #1746

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

izissise
Copy link
Contributor

#1745

Access lookup records directly instead of using an iterator
Using the slice directly make it possible to choose randomly a
record

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dns2utf8
Copy link
Contributor

Could you add a doc example showing how to use the now exposed function?

@djc
Copy link
Collaborator

djc commented Jul 28, 2022

Could you add a doc example showing how to use the now exposed function?

What's unclear about this? It seems pretty self-explanatory to me.

@izissise
Copy link
Contributor Author

I added a unit test that uses records()

Access lookup records directly instead of using an iterator
Using the slice directly make it possible to choose randomly a
record
@djc djc merged commit f37cd1c into hickory-dns:main Aug 2, 2022
@djc
Copy link
Collaborator

djc commented Aug 2, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants