Populate name_pointers correctly via MessageResponseBuilder request #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind splitting this into two commits, splitting out the field rename? I'm not very familiar with this code and splitting it up would help me review it. |
|
Sure, I guess? The name |
jeff-hiner
force-pushed
the
fix_compression
branch
from
a4ffa5d
to
b4724a5
Compare
|
Alright, I've split it up. Hope that helps! @djc |
djc
approved these changes
Aug 1, 2022
|
It seems okay. @bluejekyll please give this another look when you're back? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #1743 for single queries, which should cover most standard cases.