proto: Increase the maximum request depth to 26 #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPENPGPKEY requests in the wild has been found to exceed the maximum
request depth (20) partially due to parallel requests that increase the
counter by 2 or 4.
Increasing the value to 26 allows these requests to succeed. The test
vector used to validate this change is a validating request for
OPENPGPKEY records for the following name:
A47CB586A51ACB93ACB9EF806F35F29131548E59E2FACD58CF6232E3._openpgpkey.debian.org
See: hickory-dns#1735
bluejekyll
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENPGPKEY requests in the wild has been found to exceed the maximum request depth (20) partially due to parallel requests that increase the counter by 2 or 4.
Increasing the value to 26 allows these requests to succeed. The test vector used to validate this change is a validating request for OPENPGPKEY records for the following name:
See: #1735