Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use u16::*_be_bytes represent length field #1715

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Use u16::*_be_bytes represent length field #1715

merged 2 commits into from
Jun 4, 2022

Conversation

msoxzw
Copy link
Contributor

@msoxzw msoxzw commented Jun 4, 2022

In DoQ packet, portable code should represent length filed in big endian rather than native endian.

@bluejekyll
Copy link
Member

Thank you. I hadn't read the documentation closely enough, I thought ne was network endian.

@bluejekyll bluejekyll merged commit 327942b into hickory-dns:main Jun 4, 2022
@msoxzw msoxzw deleted the length-field branch June 9, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msoxzw @bluejekyll