Allow customizing the static hosts configuration #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows custom runtimes to provide the hosts configuration in their own way, like using io_uring instead of the std::fs::File::open() to read the system hosts file.
This allows different runtimes bring their own resolv.conf data in ways like io_uring instead of using the std::fs::File::open().
bluejekyll
requested changes
May 2, 2022
Also fixed a redundant closure and a Rustfmt issue.
bluejekyll
approved these changes
May 8, 2022
|
Totally understandable, thanks a lot for merging! It’s pretty exciting to see trust-dns working under io_uring through Cython in my toy project for asyncio, it’s only possible because you did a great job with trust-dns! |
|
I've had a lot of help from people like you. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom runtimes to provide the hosts configuration in their
own way, like using io_uring instead of the
std::fs::File::open()toread the system hosts file.
Also publicized the
resolver::system_conf::unix::parse_resolv_conffunction for the same reason.