Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: don't pull in env_logger if we aren't actually a binary #1701

Merged
merged 2 commits into from
Apr 25, 2022
Merged

deps: don't pull in env_logger if we aren't actually a binary #1701

merged 2 commits into from
Apr 25, 2022

Conversation

Noah-Kennedy
Copy link
Contributor

No description provided.

bluejekyll
bluejekyll approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. We also have this in progress pr in progress: #1667

@bluejekyll
Copy link
Member

thanks for the pr!

@bluejekyll bluejekyll merged commit 66f5be7 into hickory-dns:main Apr 25, 2022
@djc djc mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Noah-Kennedy @bluejekyll