Prevent invalid 0-length labels via from_raw_bytes
#1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
- Coverage 79.86% 78.79% -1.07%
==========================================
Files 177 185 +8
Lines 18264 18977 +713
==========================================
+ Hits 14586 14952 +366
- Misses 3678 4025 +347 |
djc
approved these changes
Apr 21, 2022
`from_raw_bytes` allowed the creation of 0-length labels. This is forbidden according to the DNS standard, e.g., RFC 2181, Section 11 "Name Syntax". The relevant sentence is > The length of any one label is limited to between 1 and 63 octets. The `from_ascii` variant already prevented the creation of 0-length labels.
jonasbb
force-pushed
the
prevent-0-length-labels
branch
from
873b6d5
to
f250738
Compare
bluejekyll
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_raw_bytesallowed the creation of 0-length labels. This is forbidden according to the DNS standard, e.g., RFC 2181, Section 11 "Name Syntax".The relevant sentence is
The
from_asciivariant already prevented the creation of 0-length labels.