Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore errors when disconnected #1695

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

edevil
Copy link
Contributor

@edevil edevil commented Apr 14, 2022

Don't emit warning when dropping cancelled requests.

Attempt to fix #1692

Don't emit warning when cancelling requests.
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Maybe add some comments about the finer points what we do and don't want to log here, and how the current iteration of the code achieves that?

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1695 (58a684a) into main (ca2c130) will decrease coverage by 1.12%.
The diff coverage is 68.51%.

@@            Coverage Diff             @@
##             main    #1695      +/-   ##
==========================================
- Coverage   79.92%   78.80%   -1.12%     
==========================================
  Files         177      185       +8     
  Lines       18309    18973     +664     
==========================================
+ Hits        14632    14950     +318     
- Misses       3677     4023     +346     

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think putting a debug or trace there would be useful.

Thanks for putting this up.

Emit a debug message when ignoring error due to disconnected stream.
@edevil
Copy link
Contributor Author

edevil commented Apr 14, 2022

No problem. Added debug message.

@djc djc merged commit 88a4d31 into hickory-dns:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Future leak warning emitted when performing queries
3 participants