Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestInfo derives Clone trait. #1693

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

humb1t
Copy link
Contributor

@humb1t humb1t commented Apr 13, 2022

In some cases I need to pass RequestInfo into another function call, but have only reference.
Clone impl would provide an ability to receive an owned copy of object.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1693 (c8954c6) into main (f91b45f) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
- Coverage   79.92%   78.80%   -1.11%     
==========================================
  Files         177      185       +8     
  Lines       18309    18971     +662     
==========================================
+ Hits        14632    14950     +318     
- Misses       3677     4021     +344     

@humb1t
Copy link
Contributor Author

humb1t commented Apr 13, 2022

I will try to write a new test and increase code coverage.

@bluejekyll
Copy link
Member

Thank you for doing that, though for future reference, we just use the coverage to help inform where we may have greater concerns as it relates to changes, generally we’re not strongly aiming to a specific coverage goal.

@humb1t
Copy link
Contributor Author

humb1t commented Apr 13, 2022

@bluejekyll it's great because my new test doesn't improve the situation =)

@bluejekyll
Copy link
Member

Thank you for the PR. Merging.

@bluejekyll bluejekyll merged commit 261a7a8 into hickory-dns:main Apr 13, 2022
@humb1t humb1t deleted the request-info-clone branch April 14, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants