Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize all addresses received by the server before attempting any r… #1690

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

bluejekyll
Copy link
Member

This verifies that an address is actually good to receive responses.

It will reject any source address on port 0, or any unspecified address, or broadcast if ipv4.

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1690 (e42929c) into main (fd2065a) will increase coverage by 0.02%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   79.88%   79.90%   +0.02%     
==========================================
  Files         183      183              
  Lines       18594    18631      +37     
==========================================
+ Hits        14853    14887      +34     
- Misses       3741     3744       +3     
Impacted Files Coverage Δ
crates/server/src/server/server_future.rs 23.00% <91.89%> (+15.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2065a...e42929c. Read the comment docs.

Copy link
Contributor

@dns2utf8 dns2utf8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good! I added some minor feedback :)
Thank you!

crates/server/src/server/server_future.rs Show resolved Hide resolved
crates/server/src/server/server_future.rs Show resolved Hide resolved
crates/server/src/server/server_future.rs Outdated Show resolved Hide resolved
crates/server/src/server/server_future.rs Show resolved Hide resolved
@bluejekyll bluejekyll merged commit 1672128 into main Apr 10, 2022
@bluejekyll bluejekyll deleted the sanitize-src-addresses branch April 10, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants