-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trust dns client cli #1680
Trust dns client cli #1680
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
- Coverage 79.88% 78.76% -1.12%
==========================================
Files 183 182 -1
Lines 18594 18802 +208
==========================================
- Hits 14853 14809 -44
- Misses 3741 3993 +252
Continue to review full report at Codecov.
|
40c7181
to
82778c7
Compare
82778c7
to
5bcef96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for failing to review this sooner. I generally don't have much time on weekends to do larger reviews, so couldn't respond to your query from yesterday sooner.
@@ -22,12 +22,40 @@ use crate::proto::rr::dnssec::rdata::DNSSECRData; | |||
use crate::rr::{Name, RData, RecordType}; | |||
use crate::serialize::txt::rdata_parsers::*; | |||
|
|||
pub(crate) trait RDataParser: Sized { | |||
use crate::serialize::txt::zone_lex::Lexer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this use
and the one below should be grouped with the block above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. That might have been a mistake. No worries on the timeline. I’ll post a patch to follow this up. I just needed to get these things bound together for some other testing. It was getting unwieldy keeping all the changes straight.
This is a new CLI for trust-dns-client that mimics the
dig
command:$> cargo install --all-features --path util --bin dns ...
The options are:
This supports all the protocols supported by trust-dns,
udp
,tcp
,tls
,https
, andquic
.Here's an example query:
Fixes: #1663