Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SvcParamKey::Unknown parsing #1678

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

jeff-hiner
Copy link
Contributor

Addresses #1677

Unfortunately it looks like this might break Key(_) parsing if they're collections, but I'm not sure what the spec says about those necessarily being collections versus arbitrary data. If so, a separate fn parse_keys should be added to svcb.rs.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1678 (5b845ec) into main (466f268) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   79.85%   79.87%   +0.02%     
==========================================
  Files         183      183              
  Lines       18602    18597       -5     
==========================================
  Hits        14853    14853              
+ Misses       3749     3744       -5     

@jeff-hiner
Copy link
Contributor Author

It looks like the cleanliness test fail is a new clippy lint from Rust 1.60

@djc
Copy link
Collaborator

djc commented Apr 7, 2022

That should be fixed if you rebase.

@jeff-hiner
Copy link
Contributor Author

Rebased.

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem reasonable. I think there's a minor potential breaking change, but it's pretty deep in the config.

@bluejekyll
Copy link
Member

Thanks for the PR!

@bluejekyll bluejekyll merged commit f07da4d into hickory-dns:main Apr 8, 2022
@jeff-hiner jeff-hiner deleted the fix_svcparamkey_unknown branch April 9, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants