Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on bad length for SVCB record #1465

Merged
merged 3 commits into from Apr 20, 2021
Merged

Conversation

bluejekyll
Copy link
Member

@oherrala had the wrong branch in the other PR, this is correct.

Fixes the panic you discovered.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1465 (43167af) into release/0.20 (7965b90) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@               Coverage Diff                @@
##           release/0.20    #1465      +/-   ##
================================================
+ Coverage         83.66%   83.70%   +0.04%     
================================================
  Files               167      167              
  Lines             15872    15876       +4     
================================================
+ Hits              13279    13288       +9     
+ Misses             2593     2588       -5     

@djc
Copy link
Collaborator

djc commented Apr 20, 2021

Looks good modulo the formatting issue.

(Personally I'd be in favor of renaming the enum variants to comply with upper_case_acronyms, but it'll be a bit of a project.)

@oherrala
Copy link
Contributor

@bluejekyll Thanks. According to my testing this seems to fix the issue!

@bluejekyll
Copy link
Member Author

Personally I'd be in favor of renaming the enum variants to comply with upper_case_acronyms, but it'll be a bit of a project.

I have a note in main that we can do that on the next major release... I'm not totally sure I want to do it, because it's an annoying breaking change without huge benefit, but we can plan it I suppose.

@bluejekyll bluejekyll merged commit f8ea42e into release/0.20 Apr 20, 2021
@bluejekyll bluejekyll deleted the fix-panic-svcb branch April 20, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants