Change Edns set_* to -> &mut Self #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jan 27, 2021
|
LGTM, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 134 134
Lines 13870 13870
=======================================
Hits 11977 11977
Misses 1893 1893 |
bluejekyll
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interested in this change? All the other
set_*methods inHeader,Message,Queryreturn&mut Selfso they can be chained, except forEdns. Seems like maybe it should also?I didn't change the now deprecated
set_option.