Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HINFO record type #1361

Merged
merged 2 commits into from Jan 21, 2021
Merged

Conversation

vlad20012
Copy link
Contributor

Add HINFO resource record type from RFC 1035. The record type is also used by RFC 8482

@vlad20012 vlad20012 force-pushed the add-hinfo-rr-type branch 3 times, most recently from ea49ece to 1d65200 Compare January 19, 2021 13:17
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1361 (6ab0819) into main (c3c4666) will increase coverage by 0.05%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   86.30%   86.35%   +0.05%     
==========================================
  Files         132      134       +2     
  Lines       13788    13870      +82     
==========================================
+ Hits        11899    11977      +78     
- Misses       1889     1893       +4     

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks for adding it.

It seems very outdated though -- out of curiosity, what's your use case for this?

@vlad20012
Copy link
Contributor Author

vlad20012 commented Jan 21, 2021

I'm making a DNS proxy/forwarder based on trust-dns. RFC 8482 seems to be a valid case.
Also, there are non-standard usages of HINFO. For example, dnscrypt-proxy has an option to block AAAA queries. If the option is set, it answers to AAAA queries with HINFO record (containing a message that ipv6 is blocked)

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants