Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async-std-resolver] Re-export AsyncStdConnection(Provider) #1354

Merged
merged 1 commit into from Jan 14, 2021

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Jan 14, 2021

Analogous to the definition of TokioAsyncResolver with re-exported TokioConnection and TokioConnectionProvider, it would be useful to have AsyncStdConnection and AsyncStdConnectionProvider re-exported in the public API of async-std-resolver, so that types like this

struct Foo<C, P> {
   // ...
   resolver: AsyncResolver<C, P>
}

can be instantiated via

type AsyncStdFoo = Foo<AsyncStdConnection, AsyncStdConnectionProvider>;

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1354 (ef3d5a6) into main (8f1a8ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         132      132           
  Lines       13775    13775           
=======================================
  Hits        11886    11886           
  Misses       1889     1889           

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bluejekyll bluejekyll merged commit ec8f839 into hickory-dns:main Jan 14, 2021
@bluejekyll
Copy link
Member

Thanks for the PR!

@mxinden
Copy link

mxinden commented Mar 11, 2021

@djc and @bluejekyll would it be possible to release a new version of async-std-resolver which includes this patch? We would like to use async-std-resolver in specific and trust-dns in general in rust-libp2p, see libp2p/rust-libp2p#1927 and libp2p/rust-libp2p#1931 both of which depend on this small change.

@bluejekyll
Copy link
Member

Yes, it's definitely possible. Let me see about a couple of PRs that might land soon before we do the next release.

@mxinden
Copy link

mxinden commented Mar 16, 2021

Thanks @bluejekyll for the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants