Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script so it will work on windows #2

Merged
merged 3 commits into from Mar 29, 2022
Merged

Fix script so it will work on windows #2

merged 3 commits into from Mar 29, 2022

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Mar 26, 2022

Apparently the PATH variable doesn't work well for windows' bash: ref
image

According to this thread the solution is just to run it via flutter/dart pub

@luanpotter luanpotter requested a review from spydon March 26, 2022 22:07
setup.sh Outdated
melos bootstrap
echo Installing Melos $version via $exec

$exec pub global activate melos $version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always be dart, doesn't work properly with flutter activate for some reason

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really? it was broken before then?

Copy link
Member

@spydon spydon Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not have run into the thing where it doesn't work, or it has been fixed, I thought that those two commands would be equivalent, but the flutter one used to cause issues when activating melos before. On their site it also says dart in the instructions. Maybe you could give some insight @Salakar?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not got much thoughts on this sorry, I've always just done dart pub global activate so may be why I've never seen issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply! Maybe it's not even an issue anymore.

@luanpotter luanpotter requested a review from spydon March 27, 2022 02:13
@luanpotter luanpotter merged commit 5e4d36d into main Mar 29, 2022
@luanpotter luanpotter deleted the luan.windows-fix branch March 29, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants