Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Cache should take key to be properly cleared #1347

Merged
merged 2 commits into from Dec 20, 2022
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented Dec 18, 2022

Description

The cache was not being cleared properly since it wasn't the correct type for the key passed in to clear and it was mapping values instead of keys in clearAll.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Migration instructions

Pass in the name of the path as a string to clear instead of a Uri.

Related Issues

Closes #1346

@spydon spydon merged commit 1a410bb into main Dec 20, 2022
@spydon spydon deleted the spydon/fix-clear-cache branch December 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio Cache
3 participants