fix(web): handle infinite value on getDuration for live streams #1287

Gustl22 · 2022-09-27T12:49:10Z

Description

Like on #1192, if calling getDuration an infinite value is returned, which isn't handled by the web implementation.

The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
I have read the Contributor Guide and followed the process outlined for submitting PRs.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
I have updated/added relevant examples in example (follwing in test: player state, improved position & duration (#1257, #1298) #1284 ).

packages/audioplayers_web/lib/util.dart

fix(web): handle infinite value on getDuration

5bb3e7b

Gustl22 requested review from luanpotter and spydon September 27, 2022 12:49

spydon reviewed Sep 27, 2022

View reviewed changes

packages/audioplayers_web/lib/util.dart Outdated Show resolved Hide resolved

Gustl22 added 4 commits September 29, 2022 00:18

Merge remote-tracking branch 'upstream/main' into fix/web-duration

93991c4

feat: improve web code

92468e9

feat: improve web code docs

7ed0771

fix(web): currentTime

a7707ac

spydon approved these changes Sep 29, 2022

View reviewed changes

Gustl22 merged commit 15f2c78 into main Sep 29, 2022

Gustl22 deleted the fix/web-duration branch September 29, 2022 12:27