Skip to content

1inch wallet #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2022
Merged

1inch wallet #779

merged 4 commits into from
Jan 26, 2022

Conversation

shoom3301
Copy link

@shoom3301 shoom3301 commented Jan 14, 2022

Description

1inch wallet Dapp browser

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

Sorry, something went wrong.

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Looking forward to integrating 1Inch Wallet
A small change is requested

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit ebbf21f into thirdweb-dev:develop Jan 26, 2022
type: 'injected',
link: `https://wallet.1inch.io?url=${window.location.host}`,
installMessage: mobileWalletInstallMessage,
mobile: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoom3301 wanted to make a note here, after testing locally it seems this wallet can work on desktop as well with a little tweaking. If you would like to add please submit a new PR with desktop: true and an update to provider. thanks again!!

Adamj1232 added a commit that referenced this pull request Jan 27, 2022
* update walletlink to 2.4.4

* 1.37.0-0.0.2  - Update yarn.lock deps to run in Node v12 container (#786)

* update yarn.lock to run in Node v12 container

* Update package.json ver

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.3  - Update to PR checklist for fork merges to run yarn with nove v12 (#787)

* Update to PR checklist for fork merges to run yarn with nove v12

* Ver inc

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.4 : use window.ethereum provider if available (#777)

* coinbase wallet use window.ethereum vs. web3

* bump minor version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Release: 1.37.1 (#788)

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1inch wallet (#779)

* 1inch wallet

* Up version due to 1inch wallet integration

* Fix lint

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Update version for release

* 1.37.1-0.0.2 - Update Walletconnect dep to 1.7.1 (#775)

* Update walletconnect to 1.7.1

* Update to latest develop version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>
Co-authored-by: Alexandr Kazachenko <shoom3301@gmail.com>
Co-authored-by: WC <677680+welps@users.noreply.github.com>
NateRobinson added a commit to NateRobinson/onboard that referenced this pull request Feb 7, 2022
* develop:
  1.37.3 Release - Develop (thirdweb-dev#810)
  1.37.2-0.0.4 - Update walletlink to 2.4.6 (thirdweb-dev#812)
  1.37.2-0.0.3 : [update] - BlankWallet -> BlockWallet rebrand changes (thirdweb-dev#804)
  1.37.2-0.0.2 : [update] - Update Gnosis SDK Packages (thirdweb-dev#809)
  1.37.2-0.0.1 : [feature] - Add Tokenary Wallet (thirdweb-dev#805)
  1.37.2 Release - Develop (thirdweb-dev#801)
  1.37.1-0.0.2 - Update Walletconnect dep to 1.7.1 (thirdweb-dev#775)
  1inch wallet (thirdweb-dev#779)
@Adamj1232
Copy link
Contributor

@shoom3301 Are you part of the 1inch team?
If so our BizDev team lead would love to connect! Feel free to shoot Shen an email at your earliest convenience shen@blocknative.com

Adamj1232 added a commit that referenced this pull request Feb 13, 2022
* Release: 1.37.1 - Master (#789)

* update walletlink to 2.4.4

* 1.37.0-0.0.2  - Update yarn.lock deps to run in Node v12 container (#786)

* update yarn.lock to run in Node v12 container

* Update package.json ver

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.3  - Update to PR checklist for fork merges to run yarn with nove v12 (#787)

* Update to PR checklist for fork merges to run yarn with nove v12

* Ver inc

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* Inc version number

* 1.37.0-0.0.4 : use window.ethereum provider if available (#777)

* coinbase wallet use window.ethereum vs. web3

* bump minor version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>

* 1.37.2 Release - Master (#802)

* update walletlink to 2.4.4

* 1.37.0-0.0.2  - Update yarn.lock deps to run in Node v12 container (#786)

* update yarn.lock to run in Node v12 container

* Update package.json ver

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.3  - Update to PR checklist for fork merges to run yarn with nove v12 (#787)

* Update to PR checklist for fork merges to run yarn with nove v12

* Ver inc

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.4 : use window.ethereum provider if available (#777)

* coinbase wallet use window.ethereum vs. web3

* bump minor version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Release: 1.37.1 (#788)

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1inch wallet (#779)

* 1inch wallet

* Up version due to 1inch wallet integration

* Fix lint

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Update version for release

* 1.37.1-0.0.2 - Update Walletconnect dep to 1.7.1 (#775)

* Update walletconnect to 1.7.1

* Update to latest develop version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>
Co-authored-by: Alexandr Kazachenko <shoom3301@gmail.com>
Co-authored-by: WC <677680+welps@users.noreply.github.com>

* 1.37.3 Release - Master (#811)

* 1.37.2-0.0.1 : [feature] - Add Tokenary Wallet (#805)

* 1.37.2-0.0.2 : [update] - Update Gnosis SDK Packages (#809)

* 1.37.2-0.0.3 : [update] - BlankWallet -> BlockWallet rebrand changes (#804)

* 1.37.2-0.0.4 - Update walletlink to 2.4.6 (#812)

* Updated version number

* Update version bump to minor release with the new SDK changes

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>
Co-authored-by: Alexandr Kazachenko <shoom3301@gmail.com>
Co-authored-by: WC <677680+welps@users.noreply.github.com>
Adamj1232 added a commit that referenced this pull request Feb 13, 2022
* update walletlink to 2.4.4

* 1.37.0-0.0.2  - Update yarn.lock deps to run in Node v12 container (#786)

* update yarn.lock to run in Node v12 container

* Update package.json ver

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.3  - Update to PR checklist for fork merges to run yarn with nove v12 (#787)

* Update to PR checklist for fork merges to run yarn with nove v12

* Ver inc

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.4 : use window.ethereum provider if available (#777)

* coinbase wallet use window.ethereum vs. web3

* bump minor version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Release: 1.37.1 (#788)

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1inch wallet (#779)

* 1inch wallet

* Up version due to 1inch wallet integration

* Fix lint

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* 1.37.1-0.0.2 - Update Walletconnect dep to 1.7.1 (#775)

* Update walletconnect to 1.7.1

* Update to latest develop version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* 1.37.2 Release - Develop (#801)

* Release: 1.37.1 - Master (#789)

* update walletlink to 2.4.4

* 1.37.0-0.0.2  - Update yarn.lock deps to run in Node v12 container (#786)

* update yarn.lock to run in Node v12 container

* Update package.json ver

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* 1.37.0-0.0.3  - Update to PR checklist for fork merges to run yarn with nove v12 (#787)

* Update to PR checklist for fork merges to run yarn with nove v12

* Ver inc

Co-authored-by: Adam Carpenter <Adam@blocknative.com>

* Inc version number

* 1.37.0-0.0.4 : use window.ethereum provider if available (#777)

* coinbase wallet use window.ethereum vs. web3

* bump minor version

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>

* Update version for release

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>

* 1.37.2-0.0.1 : [feature] - Add Tokenary Wallet (#805)

* Add Tokenary

* Fix icon name

* Update tokenary.ts

* 1.37.2-0.0.2 : [update] - Update Gnosis SDK Packages (#809)

* Update Gnosis packages

* Update renamed getSafeInfo method

* yarn.locl

* Update versioning

* 1.37.2-0.0.3 : [update] - BlankWallet -> BlockWallet rebrand changes (#804)

* BlockWallet rebrand changes

* include feature version

* 1.37.2-0.0.4 - Update walletlink to 2.4.6 (#812)

* fix: update walletlink to 2.4.6

* fix: bump minor version

* 1.37.3 Release - Develop (#810)

* 1.37.2-0.0.1 : [feature] - Add Tokenary Wallet (#805)

* 1.37.2-0.0.2 : [update] - Update Gnosis SDK Packages (#809)

* 1.37.2-0.0.3 : [update] - BlankWallet -> BlockWallet rebrand changes (#804)

* 1.37.2-0.0.4 - Update walletlink to 2.4.6 (#812)

* 1.37.3-0.0.1 : [feat] -Add DID wallet (#773)

* add did wallet

* update package.json version field

* fix lint error

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Dependabot - Bump simple-get from 2.8.1 to 2.8.2 (#818)

Bumps [simple-get](https://github.com/feross/simple-get) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/feross/simple-get/releases)
- [Commits](feross/simple-get@v2.8.1...v2.8.2)

---
updated-dependencies:
- dependency-name: simple-get
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1.37.3-0.0.2 - Update walletlink to 2.4.7 (#820)

* fix: update walletlink to 2.4.7

* fix: incremental version update

* fix: increment version

* Updated version number

* 1.37.3-0.0.3 - Wallet select error when no provider to the WalletSelect(#825)

* fix: undefined on object keys in safari

* chore: bump version

* Dependabot - Bump follow-redirects from 1.14.3 to 1.14.8 (#826)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.3 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.3...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update version bump to minor release with the new SDK changes

Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Brendan Weinstein <brendan.weinstein@coinbase.com>
Co-authored-by: Adam Carpenter <Adam@blocknative.com>
Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com>
Co-authored-by: Alexandr Kazachenko <shoom3301@gmail.com>
Co-authored-by: WC <677680+welps@users.noreply.github.com>
Co-authored-by: Ivan Grachev <ivan@ivan.lol>
Co-authored-by: Yago Pérez Vázquez <yago.perez@gnosis.pm>
Co-authored-by: ImanH <63911931+ImanH@users.noreply.github.com>
Co-authored-by: Brendan Weinstein <65564422+brendanww@users.noreply.github.com>
Co-authored-by: NateRobinson <840501291@qq.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: turtlemoji <78362532+turtlemoji@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants