Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new tag 9.0.2, since 9.0.1 is buggy #152

Closed
lastzero opened this issue Apr 12, 2016 · 12 comments
Closed

Create a new tag 9.0.2, since 9.0.1 is buggy #152

lastzero opened this issue Apr 12, 2016 · 12 comments

Comments

@lastzero
Copy link
Contributor

9.0.1 does not contain the fix I provided shortly after, see ae05fd5

@lastzero
Copy link
Contributor Author

Is this project abandoned? Your latest release is broken and your tests are failing for months.

@cryptiklemur
Copy link
Member

https://github.com/bldr-io/bldr/releases/tag/9.0.2

Nope, still working on it. Just haven't fixed the minor issues in the tests

@lastzero
Copy link
Contributor Author

I just had the impression that if somebody would use this software on a daily basis, he/she would have noticed the bug in 9.0.1 as well as the issue I mentioned in #153. These are/were not minor issues.

@cryptiklemur
Copy link
Member

This project is being used on a daily basis in many projects as a phar, and did not run into any issues with #153, nor the bug in 9.0.1.

@lastzero
Copy link
Contributor Author

So the general advice is to use the phar and not include Bldr via composer as we did, since that is not tested by the developers on a daily basis.

@cryptiklemur
Copy link
Member

The suggested install method is using a phar, and the only reasoning behind that is so you don't get dependency conflicts between bldr and your project.

@lastzero
Copy link
Contributor Author

If you look again at #153, the version conflict was within Bldr and not related to any other project at all. Also, putting a phar (or any other external dependency) in a project's code repository is not considered a best practice. Established tools like phpunit and phing use composer for installation without major issues. Actually, a phar can cause more problems - just you look at this phpunit issue to see an example: sebastianbergmann/phpunit#2015

@cryptiklemur
Copy link
Member

Why is it not considered a best practice? Do you have any sources for that?

@lastzero
Copy link
Contributor Author

@cryptiklemur
Copy link
Member

That makes no mention of phar files.

@lastzero
Copy link
Contributor Author

Right, you are allowed to make that connection yourself. A phar is nothing else that a dependency in a special file format.

@cryptiklemur
Copy link
Member

And none of the issues mentioned in that article apply to a phar file.

I'm going to leave the suggested install method with Phar for now. Thank you for your input though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants