Fix HTTPRequestLogger sharing logger among different requests

[AndersonQ]

Currently HTTPRequestLogger isn't creating a sub-logger to pass on to the request. As a result all requests share the same logger. It not only isn't the intended as well as this shared logger ends up storing all fields added to the logger for all requests.

As example, nearby-chauffeurs is producing log lines like:

{"level":"info","application":"nearby-chauffeurs","application":"nearby-chauffeurs","env":"production","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"09db14ab-7073-4367-92dd-755baa38b2d6","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"165841fa-7cb0-4f10-861e-979354819348","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"d269652a-b779-4fc5-b862-9b3e170f17ab","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"934742f2-31b3-41d5-9391-8dfcd4210000","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"d462e606-a1bf-4854-b674-01301cb6972b","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"b0dd7657-c329-4cdc-924d-19608b234525","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"23773cf1-4205-419f-9f45-28c653e17850","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"eb55a347-e606-4de9-89e2-2b24b05b377d","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"b56c37a1-68ae-4294-9e6e-f841c4071ba6","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"b960e683-3b25-46c1-8550-6d8e1b8c8ebb","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"8047a1cd-2401-405e-8281-f7362cdc5491","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"4eca9e82-ea5e-42d5-b9b4-a010d6017e23","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"bd97a9d6-7f56-45bc-a230-0c98c41e3cea","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"5668991b-3936-4c02-9638-24b649792ecc","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"f42e5cfa-3a05-42af-b836-accf35cd5a59","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"ac71cd44-984e-4a2c-9eb2-571724bc7c6b","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"85a6fbe1-a437-46da-b1dc-4024102b1482","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"865d6851-4c72-48dd-a77c-ca3063f95f46","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"11a8e104-8f7a-475c-883f-822f0b67718c","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"b4c5af8b-c000-40fd-865a-e5f8ca9820b8","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"de500fa5-d3ce-4cb8-859a-80872728becf","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"89e647af-6f8f-40f4-9b8a-a8878a1a44fe","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"57a67ac8-1210-4b0b-a19e-589691449ae3","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"f49a0846-f4b3-44ac-a39f-facb399469f5","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"07d124b8-a6cd-4b1d-9d71-9f390a9f317e","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"fda2bf24-8f00-4f37-ad71-3f3e78ae7a26","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"21cdaa20-e59b-47b7-84a8-8d8db0009b41","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"68d2dbe8-3671-47da-9c67-85059135e2c0","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"e2ae4e92-5f71-46d1-afd3-317a116f886f","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"500bc5f9-fb24-4d11-a969-d6faf519baa1","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"1f3f2a9a-0d79-4695-8dd8-d81fdbf813e2","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"c1217df8-d1fd-4aa4-8acf-eaeb361e4a87","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"0ed37664-3d79-421f-bf46-ad0896783f4a","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"ea11622f-b020-4019-afcd-bf94f4be19ca","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"941eb988-d5c9-4d43-b78b-69ad48c68947","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"14cc32a0-eacd-4990-9886-0b65e8b4f1c0","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"d84ae676-1622-4a99-98b9-597ecd81ee7a","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"a9c7eb66-7190-4c8b-8603-b1e7c1c679a7","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"89aecd6b-b8b0-4a02-a47f-e6cd0b05cbf1","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"48b4d6db-83d1-4b2f-a64d-9bb2578fe804","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"83376b98-6c26-4d0e-8007-36622f59364e","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"e162b1dd-f3ba-4f65-a124-4948aac47b0e","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"05de4114-d310-421a-8654-aba507d433d6","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"b4f60aa1-5ad8-469a-8b7c-fd973e1e87fd","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"25fc4903-0041-4cba-a72a-e6f4ef2f9d6d","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"7a21ca25-91d2-46f3-b2b3-a61427888396","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"97ede8bd-42f0-4aea-b137-f26d0f49ae80","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"e93c1ccb-0651-4b68-aa99-32e5d7c17082","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":false,"host":"nearby-chauffeurs-production.blacklane.com","ip":"185.235.235.92","params":"","path":"/","request_depth":0,"request_id":"33dfea886e4ce7d45fac76b224ccbf0d","route":"","tree_path":"","user_agent":"PostmanRuntime/7.26.3","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"43511de8-cc4e-4a08-8316-b6939a0c3602","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"2a704206-944a-4e8b-96f4-f2298f821af0","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"1786ad21-b739-49e8-86f3-17ac218d3930","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"4686077a-cd98-468d-8ce4-d479a56bdf93","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"26e31776-9011-4b77-a9f5-486e56725a7d","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"d44898cf-81ae-4632-8e57-ebb85bc059b1","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"cb2d019a-d262-4e53-8726-423dcadc10c3","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"457b1c23-2eb8-44df-8292-c4efb4fb9200","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"74c4d019-a6e4-4921-8f61-d0cb90c0b0ba","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"81788188-62ef-41cb-bb3e-030949be4e37","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"1dacc2ec-0a21-4998-8195-c86a9b54cf47","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"0474dabd-0e5f-4152-8bc1-743fec56d8f9","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"01dd8a3e-040f-41dd-8be9-b3a923dfa115","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"49be6652-4870-47db-8759-bc7d07d0d33c","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"b4083f7f-d392-407b-bf6f-5c3f24e5e524","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"274d70c5-54c7-4fe6-be2d-4b79a9cedca2","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"853f1e74-766d-4421-9376-d0a69dc16e6a","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"10393e33-3295-4b31-b0ed-312e0623aacf","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"dd2dec97-a874-4674-a151-21a8f182489e","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/live","request_depth":0,"request_id":"38aef279-e5d8-47bc-992c-f51d1d94979c","route":"","tree_path":"","user_agent":"kube-probe/1.11","verb":"GET","entry_point":true,"host":"10.51.171.139:8000","ip":"10.51.171.1","params":"","path":"/ready","request_depth":0,"request_id":"a4202e7e-221d-4d18-9a52-fe4140

This PR ensures a new sub-logger is created for each request.

[giulliano-bueno]

I really despise these "magic letters variable names" in the Go community.

[AndersonQ]

LOL, but I changed it :)

[giulliano-bueno]

LGTM.