Fix compiler warnings for nanovg wrapper #3048
Merged
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkaradzic
reviewed
Feb 27, 2023
bkaradzic
reviewed
Feb 27, 2023
bkaradzic
reviewed
Feb 27, 2023
bkaradzic
reviewed
Feb 27, 2023
bkaradzic
reviewed
Feb 27, 2023
bkaradzic
reviewed
Feb 27, 2023
Code for the nanovg wrapper was generating compiler warnings for implicit casts from int32_t to uint16_t. These casts are unavoidable due to how bgfx and nanovg APIs use different types for texture width/height.
This fixes some warnings for signed/unsigned comparsion coming from the nanovg fontstash.h header.
jay3d
pushed a commit
to jay3d/bgfx
that referenced
this pull request
Apr 24, 2023
* Fix compiler warnings for nanovg wrapper Code for the nanovg wrapper was generating compiler warnings for implicit casts from int32_t to uint16_t. These casts are unavoidable due to how bgfx and nanovg APIs use different types for texture width/height. * Fix compiler warning from nanovg fontstash.h This fixes some warnings for signed/unsigned comparsion coming from the nanovg fontstash.h header.
jay3d
pushed a commit
to jay3d/bgfx
that referenced
this pull request
Apr 24, 2023
* Fix compiler warnings for nanovg wrapper Code for the nanovg wrapper was generating compiler warnings for implicit casts from int32_t to uint16_t. These casts are unavoidable due to how bgfx and nanovg APIs use different types for texture width/height. * Fix compiler warning from nanovg fontstash.h This fixes some warnings for signed/unsigned comparsion coming from the nanovg fontstash.h header.
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
* Fix compiler warnings for nanovg wrapper Code for the nanovg wrapper was generating compiler warnings for implicit casts from int32_t to uint16_t. These casts are unavoidable due to how bgfx and nanovg APIs use different types for texture width/height. * Fix compiler warning from nanovg fontstash.h This fixes some warnings for signed/unsigned comparsion coming from the nanovg fontstash.h header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm compiling these files directly in my own project, so wanted to fix these compiler warnings (as I have them enabled for the rest of my own code)