Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin tox<4 #170

Open
3 tasks
bjlittle opened this issue Feb 22, 2023 · 7 comments
Open
3 tasks

Unpin tox<4 #170

bjlittle opened this issue Feb 22, 2023 · 7 comments
Assignees
Labels
stale A stale issue/pull-request type: tech debt Auto-labelled for debt/* branches

Comments

@bjlittle
Copy link
Owner

馃摪 Custom Issue

Unfortunately we've had to pin tox<4 in the GHAs due to our use of the tox-conda plugin not being fully compatible with tox 4.x.

However, there is movement on this, see tox-dev/tox-conda#156

Require to unpin tox in the .github/workflows:

  • ci-locks.yml
  • ci-tests.yml
  • ci-wheels.yml
@bjlittle bjlittle added the type: tech debt Auto-labelled for debt/* branches label Feb 22, 2023
@bjlittle bjlittle changed the title unpin tox<4 Unpin tox<4 Feb 22, 2023
@bjlittle bjlittle pinned this issue Feb 22, 2023
@bjlittle bjlittle self-assigned this Feb 22, 2023
@bjlittle
Copy link
Owner Author

bjlittle commented May 8, 2023

See #154

@bjlittle bjlittle unpinned this issue Jul 1, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

In order to maintain a backlog of relevant issues, we automatically label them as stale after 180 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the stale A stale issue/pull-request label Nov 5, 2023
@bjlittle bjlittle removed the stale A stale issue/pull-request label Nov 5, 2023
@trexfeathers
Copy link
Collaborator

How concerned are we about tox-conda's lack of resource? The PR for v4 compatibility - tox-dev/tox-conda#163 - has not moved for several months, and includes discussion about lack of maintainers.

Obviously right now we can keep using Tox v3, but it is a matter of time before an incompatibility or security vulnerability surfaces with either Tox v3 or with tox-conda, one which is unlikely to be fixed. 馃挘

If use of Tox is motivated by the large community - thus precluding Nox or other niche products - then we could explore something with Makefiles, although that would not offer the same environment conveniences.

See this thread for more: SciTools/iris#5184 (comment)

@bjlittle
Copy link
Owner Author

Agreed, it's a concern, has been for a while.

Difficult to judge the next best move, but a lot of folks are in the same position.

I was experimenting with dropping setuptools and moving to hatch, which would coincidentally open-up the opportunity to leverage the use of https://github.com/OldGrumpyViking/hatch-conda ... but that could simply lead to similar issues depending on the level of support and maintenance available on hatch-conda.

We could drop the use of conda and roll with pip freeze or something similar that plays ball natively with tox.

I guess there are alternative options out there, and I guess it all depends on how wedded we are to the current tooling.

Bit of a stalemate, it seems, at the moment 馃槓

@bjlittle
Copy link
Owner Author

bjlittle commented Nov 30, 2023

@trexfeathers However, there is tox-dev/tox-conda#163, which is an open PoC PR ...

Still needs some effort, but looks promising 馃

@trexfeathers
Copy link
Collaborator

trexfeathers commented Dec 1, 2023

@trexfeathers However, there is tox-dev/tox-conda#163, which is an open PoC PR ...

Still needs some effort, but looks promising 馃

I know, I referenced it in my comment! Ironically I referenced it as a bad thing 馃槀 :

The PR for v4 compatibility - tox-dev/tox-conda#163 - has not moved for several months, and includes discussion about lack of maintainers.

Copy link
Contributor

In order to maintain a backlog of relevant issues, we automatically label them as stale after 180 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the stale A stale issue/pull-request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue/pull-request type: tech debt Auto-labelled for debt/* branches
Projects
None yet
Development

No branches or pull requests

2 participants