Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.1 should be 3.0 #694

Open
ndac-todoroki opened this issue Jul 4, 2019 · 3 comments
Open

Version 2.1 should be 3.0 #694

ndac-todoroki opened this issue Jul 4, 2019 · 3 comments

Comments

@ndac-todoroki
Copy link

Description of issue

  • What are the expected results?
    incompatible changes should bump Major version up
  • What version of Distillery?
    2.1.0

According to the Semantic Versioning 2.0 docs, backward incompatible changes should bump major versions up.
スクリーンショット 2019-07-04 20 41 53

Given that Mix.Release changing to Distillery.Releases without any aliases, this should be a major version-up.

Some libraries which specify {:distillery, "~> 2.0"} like mix_erllambda are already affected by this.

@jhaagmans
Copy link

I second this. Also, I really like that there is a documented upgrade path to 2.x but I was unable to find documentation about these breaking changes in 2.1.

@shonfeder
Copy link

IMO, it is well worth cutting a new release just to get the versioning correct. We lost a half day trying to puzzle out what broke, because we didn't suspect a minor version change would break the entire release process.

@lpil
Copy link
Contributor

lpil commented Jul 13, 2019

This has been very confusing on our application. Sticking to semver would have been appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants