Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP_NAME and APP_VSN calculation needs to run in the right directory #531

Merged
merged 1 commit into from Sep 10, 2018

Conversation

mahcloud
Copy link
Contributor

@mahcloud mahcloud commented Sep 9, 2018

Summary of changes

TL;DR docs example wasn't in the right directory

I wanted to use the grep script (below) in your docs because well it looked great!
When I ran it, it was getting me the output:

grep: mix.exs: No such file or directory
grep: mix.exs: No such file or directory

The script in your docs that I'm referring to:

APP_NAME="$(grep 'app:' mix.exs | sed -e 's/\[//g' -e 's/ //g' -e 's/app://' -e 's/[:,]//g')"
APP_VSN="$(grep 'version:' mix.exs | cut -d '"' -f2)"

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be
considered, it must contain your agreement to license under the MIT license.

@bitwalker bitwalker merged commit 74e3e80 into bitwalker:master Sep 10, 2018
@bitwalker
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants