Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger #529

Merged
merged 1 commit into from Sep 5, 2018
Merged

Remove logger #529

merged 1 commit into from Sep 5, 2018

Conversation

aquarhead
Copy link
Contributor

Summary of changes

It seems Logger is not used at all, and my release works fine without it as well. I also posted a question on Elixir Forum and would love some feedback on this.

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be
considered, it must contain your agreement to license under the MIT license.

@bitwalker
Copy link
Owner

Thanks! Distillery used to use Logger, but due to issues with output being dropped when errors occur, I shifted to my own logging module, just never removed the application.

@bitwalker bitwalker merged commit 58c4890 into bitwalker:master Sep 5, 2018
@aquarhead aquarhead deleted the no-logger branch September 5, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants