Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed register_attr from required rust features when compiling for spirv #353

Merged
merged 1 commit into from Oct 13, 2022

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Oct 12, 2022

Hi.

I took the liberty of removing the register_attr feature since it's no longer supported on Rust nightly since September 2022. It doesn't seem that the feature is actively being used anywhere in the glam codebase.

I'm working on rust-gpu, which requires the Rust nightly toolchain and am in the process to update to a more recent nightly toolchain. Since one of our crates, spirv-std, is optionally dependent on glam, I'm getting compile errors because of the feature(register_attr).

@bitshifter bitshifter merged commit c34a632 into bitshifter:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants