Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass custom timeout to subsequent requests #615

Merged
merged 1 commit into from Apr 26, 2019
Merged

Conversation

bitinn
Copy link
Collaborator

@bitinn bitinn commented Apr 26, 2019

fix #612

@bitinn bitinn merged commit 49d7760 into master Apr 26, 2019
@bitinn bitinn deleted the fix-redirect-timeout branch April 27, 2019 06:35
@gdoron
Copy link

gdoron commented Oct 10, 2019

@bitinn Though one can argue it's by design, if I set a timeout of 30 seconds for my request to a.com.
a redirects me to b after 10s, b to c after 10 seconds and so on, it can go forever, while the user asked for 30s timeout.

I think you need to take the delta of the remaining time not the original timeout, no?
@bitinn

@bitinn
Copy link
Collaborator Author

bitinn commented Oct 11, 2019

@gdoron timeout option was an extension to the Fetch spec, before AbortSignal was introduced. To precisely control timeout and abort at precise timing, use it instead. (see readme for details).

@bitinn bitinn mentioned this pull request Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass request timeout on redirect
2 participants