Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Feedback (bg-change) still sending old Page: and Bank: data #2779

Open
2 tasks done
raugert opened this issue Feb 29, 2024 · 2 comments
Open
2 tasks done

[BUG] Feedback (bg-change) still sending old Page: and Bank: data #2779

raugert opened this issue Feb 29, 2024 · 2 comments
Labels
area/protocol Enhancement New feature or request
Milestone

Comments

@raugert
Copy link

raugert commented Feb 29, 2024

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

t seems that Version 3.2.2 is still sending Page: and Bank: feedback (bg_change) information. It should now be reporting Page: Row: Column: to comply with new format..
This is what is sent:
{"type":"bank_bg_change","page":1,"bank":4,"red":0,"green":0,"blue":0}
{"type":"bank_bg_change","page":1,"bank":4,"red":0,"green":0,"blue":0}
{"type":"bank_bg_change","page":1,"bank":2,"red":0,"green":0,"blue":0}
{"type":"bank_bg_change","page":1,"bank":4,"red":255,"green":0,"blue":0}

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS:
- Browser:
- Companion Version:

Additional context

No response

@raugert raugert added the BUG Something isn't working label Feb 29, 2024
@raugert raugert changed the title [BUG] Feedback (bg-change) still sending Page: and Bank: data [BUG] Feedback (bg-change) still sending old Page: and Bank: data Feb 29, 2024
@raugert
Copy link
Author

raugert commented Mar 3, 2024

Could the bg color status of ALL buttons perhaps be added as a reply to the new TCP "Surface Rescan" command in v3.x.x if it's easier than adding a new command ?? Someone also commented that it could be a #hex color instead of RGB. That's a good idea. :)
Thanks to all for your efforts.. Much appreciated.

@Julusian Julusian added Enhancement New feature or request area/protocol and removed BUG Something isn't working labels Mar 5, 2024
@Julusian Julusian added this to the v3.3 milestone Mar 5, 2024
@Julusian Julusian modified the milestones: v3.3, v3.4 May 16, 2024
@krocheck
Copy link
Member

I've added row and column to the response and left bank for backwards compatibility for now in e160e09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/protocol Enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants