Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hidden list items when <select> is at the bottom of the screen #2774

Closed
2 tasks done
chris-79 opened this issue Feb 28, 2024 · 1 comment
Closed
2 tasks done
Labels
BUG Something isn't working

Comments

@chris-79
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

<select> items are mostly hidden when they are at the bottom of the page. UI does not scroll to reveal them; only shrinking the font size makes them visible, using ⌘ -

Screen Recording:
https://scrshot.chris79.com/SDvmzfHgQjGKnjYbFyQv

Steps To Reproduce

  1. Go to a page where the selector is the last item on the page. I used Triggers
  2. Type something to start the filtering
  3. Observe only a single item in the list of selections

(See Screen Recording, above)

Expected Behavior

The selector listing should not drop below the bottom of the page/screen

Environment (please complete the following information)

- OS: macOS 14.3.1 23D60 arm64
- Browser: Brave v1.63.162
- Companion Version: 3.2.2 (3.2.2+6688-stable-7417d2a0)

Additional context

No response

@chris-79 chris-79 added the BUG Something isn't working label Feb 28, 2024
@Julusian
Copy link
Member

Julusian commented Mar 2, 2024

I've applied the patches from JedWatson/react-select#5827 and JedWatson/react-select#5716 and this seems to be behaving better.

This is in the next beta build

@Julusian Julusian closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants