Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Self & fix bug when overriding stringify! #249

Merged
merged 2 commits into from Aug 5, 2021
Merged

Use Self & fix bug when overriding stringify! #249

merged 2 commits into from Aug 5, 2021

Conversation

konsumlamm
Copy link
Contributor

@konsumlamm konsumlamm commented Aug 4, 2021 •
edited

Using Self instead of $BitFlags is cleaner imo and makes the code more readable.

There was a bug when overriding stringify!, which I fixed and added a test case for (see tests/redefinition.rs).

@konsumlamm
Use Self
a6978d9 
Fix bug when overriding `stringify!`
@konsumlamm
Remove __bitflags_stringify!
bef10f1
KodrAus
KodrAus approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @konsumlamm! This is a nice improvement

@KodrAus KodrAus merged commit 9defa89 into bitflags:master Aug 5, 2021
@konsumlamm konsumlamm deleted the self branch August 5, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@konsumlamm @KodrAus