Allows empty flag definition #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures seem unrelated as they also happen on the main branch. Maybe #216 fixes them? |
|
Thanks @thiagoarrais! Would you like to try rebasing on the current |
|
Rebased and we're back to green. |
|
Hey, @KodrAus, any blockers here? |
|
Thanks for pushing through this @thiagoarrais. I had a bit of a break from things but am taking a look through now. It looks like we've ended up with another conflict, so I'll take a look through here to save you the trouble and get this in 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Please keep in mind I'm kind of a Rust newbie and even more of a Rust macro newbie. I'm not sure this is more convoluted than necessary.