Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitflags 1.3.0 breaks nix #251

Closed
taiki-e opened this issue Aug 11, 2021 · 3 comments · Fixed by #252
Closed

bitflags 1.3.0 breaks nix #251

taiki-e opened this issue Aug 11, 2021 · 3 comments · Fixed by #252

Comments

@taiki-e
Copy link
Contributor

taiki-e commented Aug 11, 2021

#187 breaks nix because it does not respect existing repr attributes.

error[E0692]: transparent struct cannot have other repr hints
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/nix-0.22.0/src/sys/statvfs.rs:15:12
   |
13 | / libc_bitflags!(
14 | |     /// File system mount Flags
15 | |     #[repr(C)]
   | |            ^
16 | |     #[derive(Default)]
...  |
52 | |     }
53 | | );
   | |__^
   |
   = note: this error originates in the macro `::bitflags::bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0692`.

cc @flier @KodrAus

@KodrAus
Copy link
Member

KodrAus commented Aug 11, 2021

I knew the first one of these couldn't be far off...

@KodrAus
Copy link
Member

KodrAus commented Aug 11, 2021

I think we should revert the automatic addition of #[repr(transparent)] and just leave it up to callers to add whatever repr they need.

In the meantime I'll yank 1.3.0

@KodrAus
Copy link
Member

KodrAus commented Aug 11, 2021

Yanked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants