Modernization #246
Merged
Modernization #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konsumlamm
commented
Jun 27, 2021
Comment on lines
-259
to
-263
| // Re-export libcore using an alias so that the macros can work without | ||
| // requiring `extern crate core` downstream. | ||
| #[doc(hidden)] | ||
| pub extern crate core as _core; | ||
|
|
There was a problem hiding this comment.
As far as I can tell, this isn't necessary any more. The macros now use core:: instead of $crate::_core::, which seems to work fine, but I'm not entirely sure if it causes problem with macro hygiene.
There was a problem hiding this comment.
I just noticed that this breaks if someone defines mod core {} when using bitflags!, I'll put together a PR to fix that.
KodrAus
approved these changes
Jul 19, 2021
konsumlamm
added a commit
to konsumlamm/bitflags
that referenced
this pull request
Jul 19, 2021
Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the modernization parts from #205.