Let is_all() ignore extra bits (fixes #208) #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasf
commented
Feb 4, 2020
| let extra = unsafe { Flags::from_bits_unchecked(0b1000) }; | ||
| assert!(!extra.is_all()); | ||
| assert!(!(Flags::A | extra).is_all()); | ||
| assert!((Flags::ABC | extra).is_all()); |
There was a problem hiding this comment.
This was previously false, even though all flags (and one more bit) were set.
|
This looks reasonable to me! Thanks @niklasf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is_all()to match the documented behavior in the presence of extra bits:This is only relevant when
unsafe from_bits_unchecked()has been used to create an instance with bits that do not correspond to any defined flag.