Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the user-provided attributes first #173

Merged
merged 1 commit into from Mar 14, 2019
Merged

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 14, 2019

#[derive] should always come after any proc macro attribute.

`#[derive]` should always come after any proc macro attribute.
@Dylan-DPC-zz
Copy link
Member

Thanks

bors: r+

bors bot added a commit that referenced this pull request Mar 14, 2019
173: Put the user-provided attributes first r=Dylan-DPC a=nox


`#[derive]` should always come after any proc macro attribute.

Co-authored-by: Anthony Ramine <n.oxyde@gmail.com>
@nox
Copy link
Contributor Author

nox commented Mar 14, 2019

Can we release that fix in 1.0.5 now? I need it in Servo.

@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Mar 14, 2019
173: Put the user-provided attributes first r=Dylan-DPC a=nox


`#[derive]` should always come after any proc macro attribute.

Co-authored-by: Anthony Ramine <n.oxyde@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 5580478 into bitflags:master Mar 14, 2019
@KodrAus KodrAus mentioned this pull request May 2, 2019
bors bot added a commit that referenced this pull request May 2, 2019
176: Prepare for 1.0.5 release r=KodrAus a=KodrAus

[Diff since the last release](1.0.4...master)

Includes:

- #171 
- #173 
- #175 

Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants