Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the tx field of additions as txs #954

Closed
LLFourn opened this issue Apr 27, 2023 · 3 comments
Closed

Rename the tx field of additions as txs #954

LLFourn opened this issue Apr 27, 2023 · 3 comments
Assignees
@Shourya742

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Apr 27, 2023 

          Nits: Maybe rename the `tx` field of additions as `txs`. Also, maybe rename the `txout` field as `txouts`.

Originally posted by @vladimirfomene in #926 (comment)
@LLFourn LLFourn mentioned this issue Apr 27, 2023
Merged
5 tasks
@Shourya742
Copy link
Contributor

May I work on this issue? Can you please assign this to me?

@vladimirfomene
Copy link
Contributor

@Shourya742 you can go ahead and work on it. You can create a PR on top of #926 that fixes that issue.

This was referenced Apr 30, 2023
Closed
Closed
@vladimirfomene
Copy link
Contributor

I'm closing this. @Shourya742 changes were added to #976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
None yet
Projects
BDK
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LLFourn @notmandatory @vladimirfomene @nondiremanuel @Shourya742