{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":16648618,"defaultBranch":"master","name":"secp256k1","ownerLogin":"bitcoin-core","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-02-08T17:30:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13464320?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715015215.0","currentOid":""},"activityList":{"items":[{"before":"06bff6dec8d038f7b4112664a9b882293ebc5178","after":"1791f6fce4d4856a4ce2b1982768a4ffa23fcc0a","ref":"refs/heads/master","pushedAt":"2024-05-27T12:14:12.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1517: autotools: Disable eager MSan in ctime_tests\n\nebfb82ee2f8c15ae6129932380b1dfb0942ea35a ci: Add job with -fsanitize-memory-param-retval (Tim Ruffing)\ne1bef0961c53b23dbaf35f5fa87149a1aadfad37 configure: Move \"experimental\" warning to bottom (Tim Ruffing)\n55e5d975db9a641bcbeffcc3fc086e54d322fe26 autotools: Disable eager MSan in ctime_tests (Tim Ruffing)\n\nPull request description:\n\n  This is the autotools solution for #1516.\n\n  Alternatively, we could have a full-blown `--enable-msan` option, but it's more work, and I'm not convinced that it's necessary or at least much better.\n\n  hebasto If you're Concept ACK, are you willing to work on an equivalent PR for CMake?\n\nACKs for top commit:\n  hebasto:\n    ACK ebfb82ee2f8c15ae6129932380b1dfb0942ea35a, tested on Ubuntu 24.04 with different clang versions (from 15 to 18) and different build configurations. CI changes look OK as well.\n\nTree-SHA512: c083d778fd50bd35c2e29b7fe0d92b98d912ee5ac7809ae73067d050a0d3c42b3483260f1286d0023cdb802a3c3006bf932ecf60ce81b942de1c9824374c0132","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2243941934\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1517\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1517/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1517\">#1517</a>: autotools: Disable eager MSan in ctime_tests"}},{"before":"4155e62fcc9d1fdc8324b77491179c9608ec8874","after":"06bff6dec8d038f7b4112664a9b882293ebc5178","ref":"refs/heads/master","pushedAt":"2024-05-13T14:07:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1528: tests: call `secp256k1_ecmult_multi_var` with a non-`NULL` error callback\n\n9554362b1532d8292ab805cefb9c886cd55ac205 tests: call secp256k1_ecmult_multi_var with a non-NULL error callback (Nicolas Iooss)\n\nPull request description:\n\n  Hello,\n  This Pull Request fixes the issue reported in https://github.com/bitcoin-core/secp256k1/issues/1527. Function `secp256k1_ecmult_multi_var` expects to be called with a non-`NULL` `error_callback` parameter. Fix the invocation in `test_ecmult_accumulate` to do this. While at it, wrap the call in a `CHECK` macro to ensure it succeeds.\n\nACKs for top commit:\n  real-or-random:\n    utACK 9554362b1532d8292ab805cefb9c886cd55ac205\n  siv2r:\n    ACK 9554362, I have also verified that other invocations of `ecmult_multi_var` (in tests) don’t use `NULL` for the error callback function argument.\n\nTree-SHA512: 6a9f6c10c575794da75f2254d6fbbc195de889c81a371ce35ab38e2e5483aa1e25ec0bcd5aa8d6a32a1493586f73430208a4bd0613e373571d2f04d63dbc4a1c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286076990\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1528\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1528/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1528\">#1528</a>: tests: call <code>secp256k1_ecmult_multi_var</code> with a non-`NUL…"}},{"before":"7712a53061b1e36ecf47a3a46ea1e67ef31904d9","after":"4155e62fcc9d1fdc8324b77491179c9608ec8874","ref":"refs/heads/master","pushedAt":"2024-05-09T07:52:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1526: cmake: Fix `check_arm32_assembly` when using as subproject\n\n9f4c8cd730bba94f0c09cbef9b0cf9df44eb7b03 cmake: Fix `check_arm32_assembly` when using as subproject (Hennadii Stepanov)\n\nPull request description:\n\n  When integrating libsecpk1 in a downstream project like this:\n  ```cmake\n  set(SECP256K1_ASM arm32 CACHE STRING \"\" FORCE)\n  add_subdirectory(src/secp256k1)\n  ```\n  it fails to configure:\n  ```\n  CMake Error at /home/hebasto/git/bitcoin/build/check_arm32_assembly/CMakeFiles/CMakeTmp/CMakeLists.txt:21 (target_sources):\n    Cannot find source file:\n\n      /home/hebasto/git/bitcoin/cmake/source_arm32.s\n\n  CMake Error at /home/hebasto/git/bitcoin/build/check_arm32_assembly/CMakeFiles/CMakeTmp/CMakeLists.txt:20 (add_executable):\n    No SOURCES given to target: cmTC_d0f0b\n\n  CMake Error at src/secp256k1/cmake/CheckArm32Assembly.cmake:2 (try_compile):\n    Failed to generate test project build system.\n  Call Stack (most recent call first):\n    src/secp256k1/CMakeLists.txt:127 (check_arm32_assembly)\n\n  ```\n\n  This PR fixes this issue, which was overlooked in https://github.com/bitcoin-core/secp256k1/pull/1304.\n\nACKs for top commit:\n  real-or-random:\n    utACK 9f4c8cd730bba94f0c09cbef9b0cf9df44eb7b03\n  theuni:\n    utACK 9f4c8cd730bba94f0c09cbef9b0cf9df44eb7b03\n\nTree-SHA512: 47d97ad0fb2e3779523c2111ea75906671a0fb3f50646e29dee195f53106ace69af5e4abc92c765f0eee6973528ce9195b94377d0157209230c958894d4049fb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2283043849\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1526\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1526/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1526\">#1526</a>: cmake: Fix <code>check_arm32_assembly</code> when using as subproject"}},{"before":"7d0bc0870f8b09d21b815a6787901ff5b0eb9b06","after":"7712a53061b1e36ecf47a3a46ea1e67ef31904d9","ref":"refs/heads/master","pushedAt":"2024-05-07T08:36:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1524: check-abi: explicitly provide public headers\n\ndd695563e68d605b837b7813ae7bfafbf866ddff check-abi: explicitly provide public headers (Jonas Nick)\n\nPull request description:\n\n  Without this commit, the check-abi shell script outputs false positives because it consider some headers public that are actually not public.\n\nACKs for top commit:\n  real-or-random:\n    ACK https://github.com/bitcoin-core/secp256k1/pull/1524/commits/dd695563e68d605b837b7813ae7bfafbf866ddff\n  hebasto:\n    ACK dd695563e68d605b837b7813ae7bfafbf866ddff, tested on Ubuntu 24.04.\n\nTree-SHA512: b26e61639061f5fbbdd47569ba04f91c627feeefc43ec3d529a3ac4012ab6487aa1904bd38100ed190dcaebdffe60895a8c99346720d5dee84a0c457ec3b6f94","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2281273865\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1524\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1524/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1524\">#1524</a>: check-abi: explicitly provide public headers"}},{"before":"d7f6613dbbd20e07c90ab6185d62916669c33e55","after":"7d0bc0870f8b09d21b815a6787901ff5b0eb9b06","ref":"refs/heads/master","pushedAt":"2024-05-06T17:30:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1525: changelog: Correct 0.5.0 release date\n\nd45d9b74bb85ebf5a82c29d6e7f9b293212726de changelog: Correct 0.5.0 release date (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  sipa:\n    ACK d45d9b74bb85ebf5a82c29d6e7f9b293212726de\n\nTree-SHA512: 45f59cd23f5ac25bd4d9cde42aea19600cdc86a4ee98ae829c1a9c8235479792c0e5bc56d470afcf6a54cf7d57d29501fb57349aa7606ae896ca10bfaf38790b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2281360693\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1525\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1525/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1525\">#1525</a>: changelog: Correct 0.5.0 release date"}},{"before":"e3a885d42a7800c1ccebad94ad1e2b82c4df5c65","after":"d7f6613dbbd20e07c90ab6185d62916669c33e55","ref":"refs/heads/master","pushedAt":"2024-05-06T17:13:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1523: release cleanup: bump version after 0.5.0\n\n2f05e2da4b7a2a9ca67c5aa9f6ed26ac9fcc2f6e release cleanup: bump version after 0.5.0 (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  jonasnick:\n    ACK 2f05e2da4b7a2a9ca67c5aa9f6ed26ac9fcc2f6e\n\nTree-SHA512: 30e1e990b9f9b55b07895332ce46e3e12b92e5646120b504e04c8f5f88be6546c5d031ee11db8ef8226c8aacffcbaa83f96f415cc7137c4535f397a12c06bd0c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2281267329\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1523\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1523/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1523\">#1523</a>: release cleanup: bump version after 0.5.0"}},{"before":"bb528cfb08761fde75c68751de7ded747ed51e84","after":"e3a885d42a7800c1ccebad94ad1e2b82c4df5c65","ref":"refs/heads/master","pushedAt":"2024-05-06T16:56:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1522: release: prepare for 0.5.0\n\nc0e4ec3fee2d4755c0421a4568ba3253c2063180 release: prepare for 0.5.0 (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  sipa:\n    ACK c0e4ec3fee2d4755c0421a4568ba3253c2063180\n  jonasnick:\n    ACK c0e4ec3fee2d4755c0421a4568ba3253c2063180\n\nTree-SHA512: f683d084e3f3edf13892df46a869ae9a62d4e165d08aad224b352b3f6f33bc30b1e596457bfad8c411900bf334d43d6f160889acf97dca88fea2b1d88688990a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2281184742\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1522\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1522/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1522\">#1522</a>: release: prepare for 0.5.0"}},{"before":"da515074e3ebc8abc85a4fff3a31d7694ecf897b","after":"bb528cfb08761fde75c68751de7ded747ed51e84","ref":"refs/heads/master","pushedAt":"2024-05-06T15:18:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"sipa","name":"Pieter Wuille","path":"/sipa","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/548488?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1518: Add secp256k1_pubkey_sort\n\n7d2591ce12d8a9b85f210cf9d678e91cee125ee9 Add secp256k1_pubkey_sort (Jonas Nick)\n\nPull request description:\n\n  This PR adds a  `secp256k1_pubkey_sort` function the the public API which was originally part of the musig PR (#1479). However, I opened a separate PR because it adds internal functions that are also used by the WIP silent payments module.\n\nACKs for top commit:\n  sipa:\n    ACK 7d2591ce12d8a9b85f210cf9d678e91cee125ee9\n  josibake:\n    ACK https://github.com/bitcoin-core/secp256k1/pull/1518/commits/7d2591ce12d8a9b85f210cf9d678e91cee125ee9\n  real-or-random:\n    ACK 7d2591ce12d8a9b85f210cf9d678e91cee125ee9\n\nTree-SHA512: d0e4464dc9cd4bdb35cc5d9bb4c37a7b71233328319165d49bc940d8d3394a2d74a43d2f73ee7bfe8f3f90a466ee8afcdca75cfbbf3969e218d76b89f4af55fb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2246748111\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1518\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1518/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1518\">#1518</a>: Add secp256k1_pubkey_sort"}},{"before":"d8311688bd383d3a923a1b11789cded3cc8e5e03","after":"da515074e3ebc8abc85a4fff3a31d7694ecf897b","ref":"refs/heads/master","pushedAt":"2024-04-22T15:17:43.000Z","pushType":"push","commitsCount":18,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm\n\n4c341f89ab704205a89b5c5d404ed60f381f7c48 Add changelog entry for SDMC (Pieter Wuille)\na043940253e1e44ea6ccd3e89a7fd807b56817ef Permit COMB_BITS < 256 for exhaustive tests (Pieter Wuille)\n39b2f2a32102b9319c8958715c1e708e95e06191 Add test case for ecmult_gen recoded = {-1,0,1} (Pieter Wuille)\n644e86de9a8f4d8faf4b6d9e2780157ab5a72314 Reintroduce projective blinding (Pieter Wuille)\n07810d9abb8377e8f0056032bca51f8ca54ed18f Reduce side channels from single-bit reads (Peter Dettman)\na0d32b597d4f9c8a20547dd21677716d4df8da54 Optimization: use Nx32 representation for recoded bits (Peter Dettman)\ne03dcc44b5fa9cac5aa6ebe855f825116b24791a Make secp256k1_scalar_get_bits support 32-bit reads (Pieter Wuille)\n5005abee60ad03d2967c9aadf4e25d208c90d98a Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t (Pieter Wuille)\n6247f485b6be461d5036608b9e8cd2f5adc912f1 Optimization: avoid unnecessary doublings in precomputation (Peter Dettman)\n15d0cca2a6920400ce061c397203dbb931fc8dcd Optimization: first table lookup needs no point addition (Pieter Wuille)\n7a33db35cd5ca3f71510b115a0cd57d2b1fb71b0 Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset (Pieter Wuille)\ned2a056f3da9c3d75a1604832b4cd53e1871e784 Provide 3 configurations accessible through ./configure (Pieter Wuille)\n5f7be9f6a53a99f4a7d00e79c1dfe37eebe6edf8 Always generate tables for current (blocks,teeth) config (Pieter Wuille)\nfde1dfcd8d0a2a6444491b235d9ae2926f4ad7f4 Signed-digit multi-comb ecmult_gen algorithm (Peter Dettman)\n486518b35026715bd286bf1595ab0f51968c4b6f Make exhaustive tests's scalar_inverse(&x,&x) work (Pieter Wuille)\nab45c3e0892ec6cffed714d89fb146bee694fcb2 Initial gej blinding -> final ge blinding (Pieter Wuille)\naa00a6b8924a7095e9bf650fcda4e69551af69b2 Introduce CEIL_DIV macro and use it (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  real-or-random:\n    reACK 4c341f89ab704205a89b5c5d404ed60f381f7c48\n  jonasnick:\n    ACK 4c341f89ab704205a89b5c5d404ed60f381f7c48\n  stratospher:\n    ACK 4c341f8. Did [these benchmarks](https://github.com/bitcoin-core/secp256k1/pull/1058#issuecomment-1002807283) and saw a 12.4% on gcc 13.2.0 and 11.5% on clang 15.0.0. Also summarised how the precomputed table generation works [here](https://github.com/stratospher/blogosphere/blob/main/sdmc.md) for future me :)\n\nTree-SHA512: 9a11138e4fb98b98e85c82cd46ed78b29fbe63d6efe61654ef519a64b1e175d63395a8a931c1646f9df8c7daacd796d5fe2384899d5a13a2c7ed2ded696ceed5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1090745444\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1058\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1058/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1058\">#1058</a>: Signed-digit multi-comb ecmult_gen algorithm"}},{"before":"4b77fec67a80af41a538b6195317229c77101f87","after":"d8311688bd383d3a923a1b11789cded3cc8e5e03","ref":"refs/heads/master","pushedAt":"2024-04-04T09:52:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1515: ci: Note affected clangs in comment on ASLR quirk\n\na85e2233e701c3e3dd1673d187d7d8806de387ff ci: Note affected clangs in comment on ASLR quirk (Tim Ruffing)\n\nPull request description:\n\n  Resolves #1506.\n\nACKs for top commit:\n  fanquake:\n    ACK a85e2233e701c3e3dd1673d187d7d8806de387ff\n\nTree-SHA512: a82d6f5e57175434c1f66c7b01c90eb2877db794d7f5213b3652ecb51ebb7c03ff13ab13424b3e6d41b9eaa504af330f16855e32e63d1805c1a475f462c6da66","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2225005901\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1515\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1515/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1515\">#1515</a>: ci: Note affected clangs in comment on ASLR quirk"}},{"before":"05bfab69aef3622f77f754cfb01220108a109c91","after":"4b77fec67a80af41a538b6195317229c77101f87","ref":"refs/heads/master","pushedAt":"2024-04-03T17:06:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1512: msan: notate more variable assignments from assembly code\n\nf7f0184ba1358cb8659607d2d0105628cb130e4f msan: notate more variable assignments from assembly code (Cory Fields)\na61339149f1faae3c5d8e9ba533d96ff1ca2c32d change inconsistent array param to pointer (Cory Fields)\n\nPull request description:\n\n  This was missed in 31ba40494428dcbf2eb5eb6f2328eca91b0b0746 because older versions of clang did not complain about it. But clang-17, at least, does.\n\n  The array-as-a-param makes this annoying because `sizeof(l)` is not helpful. I'd be happy to change the size calculation if there are any better suggestions or strong preferences.\n\nACKs for top commit:\n  sipa:\n    utACK f7f0184ba1358cb8659607d2d0105628cb130e4f\n  real-or-random:\n    ACK f7f0184ba1358cb8659607d2d0105628cb130e4f tests work fine with clang 17 and `./configure CFLAGS=\"-fsanitize=memory -fsanitize-memory-track-origins=2 -fno-omit-frame-pointer -g -O1 -fno-optimize-sibling-calls\" CC=clang`\n\nTree-SHA512: 8ab22209ef322a10f500b123c82ae5e7141ae1da0e7a890cbf90bd7d2eb11f397db4ccfe15a1666f2f49228585cccbf5bec741effebd1e2c6012cb7ea1689675","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2211104068\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1512\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1512/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1512\">#1512</a>: msan: notate more variable assignments from assembly code"}},{"before":"427e86b9edcaa5cb19e71233ad93c2ec60dff10f","after":"05bfab69aef3622f77f754cfb01220108a109c91","ref":"refs/heads/master","pushedAt":"2024-03-20T12:25:41.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1507: ci: Add workaround for ASLR bug in sanitizers\n\na5e8ab248447864873eae9b00f94175594477d66 ci: Add sanitizer env variables to debug output (Tim Ruffing)\n84a93de4d2ba1063aa3d67d592db8ae0bb4a307e ci: Add workaround for ASLR bug in sanitizers (Tim Ruffing)\n\nPull request description:\n\n  Fixes #1506.\n\n  This also adds the sanitizer env variables to our debug output as suggested in the same issue.\n\nACKs for top commit:\n  sipa:\n    utACK a5e8ab248447864873eae9b00f94175594477d66\n  jonasnick:\n    ACK a5e8ab248447864873eae9b00f94175594477d66\n\nTree-SHA512: 5162d14eeec01e088c600ed77e21c5ffd4dec23327b7e81b5ecac59b7c535cac97cd7b7b744c767766036dfc6d9152a9933eb326cf4065d56c46e2ee858da662","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2195412286\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1507\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1507/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1507\">#1507</a>: ci: Add workaround for ASLR bug in sanitizers"}},{"before":"cdc9a6258e99f0e1e2cdeb9951ce052f76755fe7","after":"427e86b9edcaa5cb19e71233ad93c2ec60dff10f","ref":"refs/heads/master","pushedAt":"2024-02-27T17:17:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1490: tests: improve fe_sqr test (issue #1472)\n\n2028069df2e16a05b332ae24c7ae63791f461063 doc: clarify input requirements for secp256k1_fe_mul (Sebastian Falbesoner)\n11420a7a2836114393b70f4d10bb81921403a360 tests: improve fe_sqr test (Sebastian Falbesoner)\n\nPull request description:\n\nACKs for top commit:\n  real-or-random:\n    utACK 2028069df2e16a05b332ae24c7ae63791f461063\n  jonasnick:\n    ACK 2028069df2e16a05b332ae24c7ae63791f461063\n\nTree-SHA512: bb01bf6ceb34f0475a60b8dcb0cec000859a0c20f1009426bd8cab609f1941f44f84802f1565a719f7d2a55466076fb1591a353b1b75e6c0ceac44806d908176","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2111264166\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1490\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1490/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1490\">#1490</a>: tests: improve fe_sqr test (issue <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2054992308\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1472\" data-hovercard-type=\"issue\" data-hovercard-url=\"/bitcoin-core/secp256k1/issues/1472/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/issues/1472\">#1472</a>)"}},{"before":"d926510cf76d9e7614aa4b8bffbaf95a07d5349d","after":"cdc9a6258e99f0e1e2cdeb9951ce052f76755fe7","ref":"refs/heads/master","pushedAt":"2024-02-27T15:18:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1489: tests: add missing fe comparison checks for inverse field test cases\n\ne7bdddd9c9c4b9f4f44420f3c7eeaef44f0c82ff refactor: rename `check_fe_equal` -> `fe_equal` (Sebastian Falbesoner)\n00111c9c563367cf5163cda1ce6b9c6f032cea43 tests: add missing fe comparison checks for inverse field test cases (Sebastian Falbesoner)\n\nPull request description:\n\nACKs for top commit:\n  real-or-random:\n    utACK e7bdddd9c9c4b9f4f44420f3c7eeaef44f0c82ff\n  jonasnick:\n    ACK e7bdddd9c9c4b9f4f44420f3c7eeaef44f0c82ff\n\nTree-SHA512: 1d14cb87bf3d190be6e11ae205ed25090758aae589f50793d9bcbdb3c04378ca08f6a3d41567fdf472786ea3234cf1f3b9c95ece8b605b4a7667a81a27b249e2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2111213741\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1489\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1489/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1489\">#1489</a>: tests: add missing fe comparison checks for inverse fiel…"}},{"before":"0653a25d50f67c68bd2d196ecc7eddab067d95ef","after":"d926510cf76d9e7614aa4b8bffbaf95a07d5349d","ref":"refs/heads/master","pushedAt":"2024-02-27T13:47:34.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1496: msan: notate variable assignments from assembly code\n\n31ba40494428dcbf2eb5eb6f2328eca91b0b0746 msan: notate variable assignments from assembly code (Cory Fields)\ne7ea32e30a9f628855c4ddc7533ebd5d2013dc40 msan: Add SECP256K1_CHECKMEM_MSAN_DEFINE which applies to memory sanitizer and not valgrind (Cory Fields)\n\nPull request description:\n\n  msan isn't smart enough to see that these are set without some help.\n\n  This was pointed out here: https://github.com/bitcoin-core/secp256k1/pull/1169#issuecomment-1370003449\n\n  With this commit, msan output is clean even with x86 asm turned on.\n\nACKs for top commit:\n  real-or-random:\n    utACK 31ba40494428dcbf2eb5eb6f2328eca91b0b0746\n  hebasto:\n    re-ACK 31ba40494428dcbf2eb5eb6f2328eca91b0b0746.\n\nTree-SHA512: c9c51fe542247e1e0a93f6d0063d119cf777ca8c1b7e9c8e45e168a2020dc503872eb2a78004725de81267a3ce78c923be1f8546fb92a3e95fc7ef034e5ba932","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2147222526\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1496\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1496/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1496\">#1496</a>: msan: notate variable assignments from assembly code"}},{"before":"248362729929892f4a1da286429fc266c50bce2c","after":"0653a25d50f67c68bd2d196ecc7eddab067d95ef","ref":"refs/heads/master","pushedAt":"2024-01-25T13:57:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1486: ci: Update cache action\n\n94a14d5290e6ca805f23b1a7baca197d15e55f84 ci: Update cache action (Hennadii Stepanov)\n\nPull request description:\n\n  This PR fixes deprecation warnings for Node.js 16 actions in the GHA CI.\n\n  See:\n  - https://github.com/marketplace/actions/cache\n  - https://github.com/actions/cache/releases/tag/v4.0.0\n\nACKs for top commit:\n  real-or-random:\n    ACK 94a14d5290e6ca805f23b1a7baca197d15e55f84 thanks!\n\nTree-SHA512: 6f520908aaadf179955255a2b3a93c2cb96f23cf3a9d00a53b3ae635007983337f1a768cb6039e0e0b1bc9630930b143dd1c650f366185fd20727ab97221519b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2100260268\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1486\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1486/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1486\">#1486</a>: ci: Update cache action"}},{"before":"5ad3aa3dcd2315902823dea6e22937df5737460d","after":"248362729929892f4a1da286429fc266c50bce2c","ref":"refs/heads/master","pushedAt":"2024-01-23T19:41:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1483: cmake: Recommend native CMake commands in README\n\n3777e3f36a61a05da19d5c6575fdd59288848948 cmake: Recommend native CMake commands in README (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  hebasto:\n    ACK 3777e3f36a61a05da19d5c6575fdd59288848948\n  jonasnick:\n    ACK 3777e3f36a61a05da19d5c6575fdd59288848948\n\nTree-SHA512: 884e54ee3ec9617edbb98d439ccd3fa8b3d9448969a4f5a88d22d034329ec5024238d6f91e28160f82f77eed678100266ac8b5495b6072b48caa0514a9cec881","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2086308482\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1483/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1483\">#1483</a>: cmake: Recommend native CMake commands in README"}},{"before":"e4af41c61b0bb55fc9614cb39df8e455715b4dd4","after":"5ad3aa3dcd2315902823dea6e22937df5737460d","ref":"refs/heads/master","pushedAt":"2024-01-23T19:30:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1484: tests: Drop redundant _scalar_check_overflow calls\n\n51df2d9ab3a61dafee2c12b39e651d93a6b5be76 tests: Drop redundant _scalar_check_overflow calls (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  stratospher:\n    ACK 51df2d9.\n  jonasnick:\n    ACK 51df2d9ab3a61dafee2c12b39e651d93a6b5be76\n\nTree-SHA512: 52caff34b0cbb8570b6aa962c86c249e216d3a78661715c6adf6804379c60be049e36fcb714cd562d350787949dfccf95d0b9a885480e08513664864abd36928","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2086488306\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1484\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1484/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1484\">#1484</a>: tests: Drop redundant _scalar_check_overflow calls"}},{"before":"3bf4d68fc00a44686a15031b181d513e3f3b13f5","after":"e4af41c61b0bb55fc9614cb39df8e455715b4dd4","ref":"refs/heads/master","pushedAt":"2024-01-17T12:20:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1249: cmake: Add `SECP256K1_LATE_CFLAGS` configure option\n\n42f8c5140227dbdd8ae7eaaecd914e705e1b12d0 cmake: Add `SECP256K1_LATE_CFLAGS` configure option (Hennadii Stepanov)\n\nPull request description:\n\n  This PR enables users to override compiler flags that have been set by the CMake-based build system, such as warning flags.\n\n  The Autotools-based build system has the same feature out-of-the-box.\n\n  See more details [here](https://github.com/bitcoin-core/secp256k1/issues/1235#issuecomment-1465330925).\n\n  Here are some examples of the new option usage:\n  ```\n  cmake -S . -B build -DSECP256K1_LATE_CFLAGS=\"-Wno-extra -Wlong-long\"\n  ```\n\n  ```\n  cmake -S . -B build -DSECP256K1_BUILD_EXAMPLES=ON -DSECP256K1_LATE_CFLAGS=-O1\n  cmake --build build\n  ...\n  In function ‘secp256k1_ecmult_strauss_wnaf’,\n      inlined from ‘secp256k1_ecmult’ at /home/hebasto/git/secp256k1/src/ecmult_impl.h:353:5:\n  /home/hebasto/git/secp256k1/src/ecmult_impl.h:291:5: warning: ‘aux’ may be used uninitialized [-Wmaybe-uninitialized]\n    291 |     secp256k1_ge_table_set_globalz(ECMULT_TABLE_SIZE(WINDOW_A) * no, state->pre_a, state->aux);\n        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n  In file included from /home/hebasto/git/secp256k1/src/secp256k1.c:29:\n  /home/hebasto/git/secp256k1/src/ecmult_impl.h: In function ‘secp256k1_ecmult’:\n  /home/hebasto/git/secp256k1/src/group_impl.h:174:13: note: by argument 3 of type ‘const secp256k1_fe *’ to ‘secp256k1_ge_table_set_globalz’ declared here\n    174 | static void secp256k1_ge_table_set_globalz(size_t len, secp256k1_ge *a, const secp256k1_fe *zr) {\n        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n  In file included from /home/hebasto/git/secp256k1/src/secp256k1.c:30:\n  /home/hebasto/git/secp256k1/src/ecmult_impl.h:345:18: note: ‘aux’ declared here\n    345 |     secp256k1_fe aux[ECMULT_TABLE_SIZE(WINDOW_A)];\n        |                  ^~~\n  ...\n  ```\n\n  Please note that in the last case providing `env CFLAGS=-O1` or `-DCMAKE_C_FLAGS=-O1` won't work.\n\nACKs for top commit:\n  real-or-random:\n    ACK 42f8c5140227dbdd8ae7eaaecd914e705e1b12d0\n\nTree-SHA512: 2b152e420a4a8ffd5f67857de03ae5ba9f2223e535ac01a867c1025e0619180d8255fdd1e5fb8279b290f0a1c96bcc874043ef968fcd99b1ff4e13041a91b1e1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1641032447\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1249\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1249/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1249\">#1249</a>: cmake: Add <code>SECP256K1_LATE_CFLAGS</code> configure option"}},{"before":"44378867a0102ff634e93d39ea576e865231c778","after":"3bf4d68fc00a44686a15031b181d513e3f3b13f5","ref":"refs/heads/master","pushedAt":"2024-01-17T12:20:27.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1482: build: Clean up handling of module dependencies\n\ne6822678ea05c431b4f43be9dfbde54e0f7f645b build: Error if required module explicitly off (Tim Ruffing)\n89ec583ccf01d9201fdab6a6c1682e6c27224b16 build: Clean up handling of module dependencies (Tim Ruffing)\n\nPull request description:\n\n  This is a cleanup which makes it easier to add further modules with dependencies, e.g., in #1452. The diff looks larger than it is because I also reordered the modules and made the order consistent between CMake and autotools.\n\n  (We noticed that the current logic could be improved in https://github.com/BlockstreamResearch/secp256k1-zkp/pull/275.)\n\nACKs for top commit:\n  jonasnick:\n    ACK e6822678ea05c431b4f43be9dfbde54e0f7f645b\n  hebasto:\n    ACK e6822678ea05c431b4f43be9dfbde54e0f7f645b.\n\nTree-SHA512: 040e791e5b5b9b8845a39632633a45ca759391455910bdefba2b7b77c6340e65df6eda18199ae2ad65c30ee2fc6630471437aec143c26fe09ae4c11409a37622","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2084020195\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1482\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1482/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1482\">#1482</a>: build: Clean up handling of module dependencies"}},{"before":"a9db9f2d75ac9df0312dec0c329266969bcc2946","after":"44378867a0102ff634e93d39ea576e865231c778","ref":"refs/heads/master","pushedAt":"2024-01-16T20:01:52.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1468: v0.4.1 release aftermath\n\nb37fdb28ce373e359e4d3a9727693b724db31676 check-abi: Minor UI improvements (Tim Ruffing)\nad5f589a94cfa23f09ef9424d779a5c9054f6572 check-abi: Default to HEAD for new version (Tim Ruffing)\n9fb7e2f1568c302eb9f69d6e585e6ce129ea0093 release process: Style and formatting nits (Tim Ruffing)\ne7053d065b9b2c7a67dd7908598e51b739cc2f77 release process: Add email step (Tim Ruffing)\n429d21dc79ef4a9f0b3837c530a06d581baf067f release process: Run sanity checks on release PR (Tim Ruffing)\n\nPull request description:\n\nACKs for top commit:\n  hebasto:\n    ACK b37fdb28ce373e359e4d3a9727693b724db31676.\n  jonasnick:\n    ACK b37fdb28ce373e359e4d3a9727693b724db31676\n\nTree-SHA512: 6e18a5b897d29a3dd3a73ba81623dd91c04fa6730fb56374b924dc84baaec8c55d0c689ee1a41dab9a03ccd566082fc59ffb5d68cafd536a136fc7aaac2d8ef5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2052734893\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1468\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1468/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1468\">#1468</a>: v0.4.1 release aftermath"}},{"before":"74b7c3b53e1e2ba3f3ddd9a2b7d2fc11f0a38f2f","after":"a9db9f2d75ac9df0312dec0c329266969bcc2946","ref":"refs/heads/master","pushedAt":"2024-01-09T17:59:43.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1480: Get rid of untested sizeof(secp256k1_ge_storage) == 64 code path\n\nba5d72d62659f9305d2be30b2ac89ce9480a0e78 assumptions: Use new STATIC_ASSERT macro (Tim Ruffing)\ne53c2d9ffc0b0096881e30e388c3fb040f35e05d Require that sizeof(secp256k1_ge_storage) == 64 (Tim Ruffing)\nd0ba2abbff2dcd4ca355f648d61fc6520f929949 util: Add STATIC_ASSERT macro (Tim Ruffing)\n\nPull request description:\n\n  This gets rid of an untested code path. Resolves https://github.com/bitcoin-core/secp256k1/issues/1352.\n\n  This is a bit opinionated in the sense that it adds a static assertion where it's needed in `secp256k1_pubkey_save` and `secp256k1_pubkey_load`. I think this is justified in this case. It helps the reviewer verify that these functions are correct.\n\n  See individual commit messages.\n\nACKs for top commit:\n  sipa:\n    utACK ba5d72d62659f9305d2be30b2ac89ce9480a0e78\n  jonasnick:\n    ACK ba5d72d62659f9305d2be30b2ac89ce9480a0e78\n\nTree-SHA512: 2553c0610b62bcda6d4ef26eb26b5b2e07acf723bcd299691a2d02da57af22b8763f63c2d4adb17d30de8825b6157be6e4f0398147854fbabdf8b865fb0b5c88","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2070682744\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1480\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1480/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1480\">#1480</a>: Get rid of untested sizeof(secp256k1_ge_storage) == 64 c…"}},{"before":"d373bf6d08c82ac5496bf8103698c9f54d8d99d2","after":"74b7c3b53e1e2ba3f3ddd9a2b7d2fc11f0a38f2f","ref":"refs/heads/master","pushedAt":"2024-01-09T16:52:07.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1476: include: make docs more consistent\n\nda7bc1b803b14274bc1687514e5da6a3e1cd9765 include: in doc, remove article in front of \"pointer\" (Jonas Nick)\naa3dd5280b4a046c03bd344bfd7f1499199a1f3c include: make doc about ctx more consistent (Jonas Nick)\ne3f690015a21d6404cdec30666f721001b493172 include: remove obvious \"cannot be NULL\" doc (Jonas Nick)\n\nPull request description:\n\nACKs for top commit:\n  sipa:\n    ACK da7bc1b803b14274bc1687514e5da6a3e1cd9765\n  real-or-random:\n    ACK da7bc1b803b14274bc1687514e5da6a3e1cd9765\n\nTree-SHA512: 809f312fa0cd1e9502ac79b8a1c502b87e6dfc2db8ad6bbd96d7ddbdaadad0c3b6110fa704b770c353cd34d5bf5547541cbb5f2779425d7419b584e721c854c2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2066045509\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1476\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1476/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1476\">#1476</a>: include: make docs more consistent"}},{"before":"79e094517c9e69db85a354da5d5e3bb303bfc64f","after":"d373bf6d08c82ac5496bf8103698c9f54d8d99d2","ref":"refs/heads/master","pushedAt":"2024-01-04T16:48:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1474: tests: restore scalar_mul test\n\n3dbfb48946b9d2a98acef23674617510cf1b3386 tests: restore scalar_mul test (Jonas Nick)\n\nPull request description:\n\n  Without this commit, the res[i][1] test vectors are unused. They were introduced to test the correctness of scalar_sqr(x) and scalar_mul(x, x). These tests were deleted as part of removing scalar_sqr in commit\n  [5437e7bdfbffddf69fdf7b4af7e997c78f5dafbf](https://github.com/bitcoin-core/secp256k1/commit/5437e7bdfbffddf69fdf7b4af7e997c78f5dafbf#diff-c2d5f1f7616875ab71cd41b053cfb428696988ff89642b931a0963d50f34f7e8L2195).\n\n  Discovered in https://github.com/bitcoin-core/secp256k1/discussions/1463 by Coding-Enthusiast (thanks!).\n\nACKs for top commit:\n  real-or-random:\n    utACK 3dbfb48946b9d2a98acef23674617510cf1b3386\n\nTree-SHA512: 914e08db3efaa1cef546a9730096e740478c422d41fedb2b71ec3a7ea962f81740a05dc7e7c1fb191088f6d38b5690479c7d0864ca8abf2b2e9c4334f03ca605","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2065900849\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1474\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1474/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1474\">#1474</a>: tests: restore scalar_mul test"}},{"before":"efe85c70a2e357e3605a8901a9662295bae1001f","after":"79e094517c9e69db85a354da5d5e3bb303bfc64f","ref":"refs/heads/master","pushedAt":"2024-01-04T16:39:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1473: Fix typos\n\nd77170a88d0d6f27d0b90057fa7cd25ec74e3850 Fix typos (shuoer86)\n\nPull request description:\n\n  Fix some typos caught by spell checker\n\nACKs for top commit:\n  real-or-random:\n    utACK d77170a88d0d6f27d0b90057fa7cd25ec74e3850\n\nTree-SHA512: 18722459b0b8d906ad93dd0f159b0a70a338d08c121ce6523bb6be70be33febdffa5241efc000acf18c70a845795b0582599a71d6dd25b663fee1358c8d38c85","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2062318334\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1473\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1473/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1473\">#1473</a>: Fix typos"}},{"before":"1ad5185cd42c0636104129fcc9f6a4bf9c67cc40","after":"efe85c70a2e357e3605a8901a9662295bae1001f","ref":"refs/heads/master","pushedAt":"2023-12-21T16:00:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1466: release cleanup: bump version after 0.4.1\n\n4b2e06f460a513bff630fa60c537d290589049a8 release cleanup: bump version after 0.4.1 (Jonas Nick)\n\nPull request description:\n\nACKs for top commit:\n  hebasto:\n    ACK 4b2e06f460a513bff630fa60c537d290589049a8\n  real-or-random:\n    ACK 4b2e06f460a513bff630fa60c537d290589049a8\n\nTree-SHA512: b1c764f0f13b259bcd6f2a8988dd92cefe7791dfed337c8d54bd148ea0b93dc1c931c9ff310fd5503432250a8359dd7b09dea6e8f66c0300c47a68349077d8f8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2052682375\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1466\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1466/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1466\">#1466</a>: release cleanup: bump version after 0.4.1"}},{"before":"1a81df826e2a24a1656fc28fc3076b62562216d9","after":"1ad5185cd42c0636104129fcc9f6a4bf9c67cc40","ref":"refs/heads/master","pushedAt":"2023-12-21T15:51:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1465: release: prepare for 0.4.1\n\n672053d8015fe8ac8d411ef79fbcd97abc045b56 release: prepare for 0.4.1 (Jonas Nick)\n\nPull request description:\n\nACKs for top commit:\n  sipa:\n    ACK 672053d8015fe8ac8d411ef79fbcd97abc045b56\n  real-or-random:\n    ACK 672053d8015fe8ac8d411ef79fbcd97abc045b56\n  hebasto:\n    ACK 672053d8015fe8ac8d411ef79fbcd97abc045b56\n\nTree-SHA512: de78fd4588061ffc9b869d86c6d639dce06ed215c0614a888827054014c073a97b106268e5d5773967f9407c70ddc0f27326ee9c858dce5d52af7f33d2d46b69","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2052615689\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1465\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1465/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1465\">#1465</a>: release: prepare for 0.4.1"}},{"before":"77af1da9f631fa622fb5b5895fd27be431432368","after":"1a81df826e2a24a1656fc28fc3076b62562216d9","ref":"refs/heads/master","pushedAt":"2023-12-20T22:10:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"jonasnick","name":"Jonas Nick","path":"/jonasnick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2582071?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1380: Add ABI checking tool for release process\n\n74a4d974d5c81fbc437287dffc453028509682ab doc: Add ABI checking with `check-abi.sh` to the Release Process (Hennadii Stepanov)\ne7f830e32c61ac4cf6c562b477063ccf35940ba9 Add `tools/check-abi.sh` (Hennadii Stepanov)\n\nPull request description:\n\nACKs for top commit:\n  real-or-random:\n    ACK 74a4d974d5c81fbc437287dffc453028509682ab it compares the right commits now\n  jonasnick:\n    re-Concept ACK 74a4d974d5c81fbc437287dffc453028509682ab\n\nTree-SHA512: bcca5246837f899d43ced3b0099a8e123f4fd2db7d15684bda22657649521db0c87f76696bfbd93b4dfdec6c4851e99c26c7e37cc5a1a78e9b1a296850a067fe","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1810005165\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1380\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1380/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1380\">#1380</a>: Add ABI checking tool for release process"}},{"before":"5e9a4d7aecadf42f9a22daa2ea7d1502308f13ad","after":"77af1da9f631fa622fb5b5895fd27be431432368","ref":"refs/heads/master","pushedAt":"2023-12-11T08:20:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#1455: doc: improve secp256k1_fe_set_b32_mod doc\n\n3928b7c38367947756b7d506f431bfb7bbbac5d0 doc: improve secp256k1_fe_set_b32_mod doc (Coding Enthusiast)\n\nPull request description:\n\n  As discussed in #1453\n  This only changes the `secp256k1_fe_impl_set_b32_mod` comment since I think `secp256k1_fe_set_b32_limit` doc is clear enough.\n\nACKs for top commit:\n  sipa:\n    ACK 3928b7c38367947756b7d506f431bfb7bbbac5d0\n  theStack:\n    ACK 3928b7c38367947756b7d506f431bfb7bbbac5d0\n\nTree-SHA512: ad62c1b72d6a487473b182e6aadc7765711385add8c6576bf15c2015db82721f19e3d635f7a29316c2ee7e3c73bc55e2cd4f46ec13180be93d6fe8641f47e7d2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2031925867\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/1455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/1455/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/1455\">#1455</a>: doc: improve secp256k1_fe_set_b32_mod doc"}},{"before":"4197d667ec90c35ad7a7291d760a7fb35d6963f8","after":"5e9a4d7aecadf42f9a22daa2ea7d1502308f13ad","ref":"refs/heads/master","pushedAt":"2023-12-07T08:26:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"real-or-random","name":"Tim Ruffing","path":"/real-or-random","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1071625?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/secp256k1#990: Add comment on length checks when parsing ECDSA sigs\n\ne02f313b1f251ccb363ae1ac24016d87c1be9009 Add comment on length checks when parsing ECDSA sigs (Tim Ruffing)\n\nPull request description:\n\n  I claim the check can be removed but I don't want to touch this\n  stable and well-tested code.\n\n  On the way, we fix grammar in another comment.\n\nACKs for top commit:\n  sipa:\n    ACK e02f313b1f251ccb363ae1ac24016d87c1be9009\n  RandyMcMillan:\n    ACK e02f313\n\nTree-SHA512: f82691a8f5db82a1e9683e52ce8e952ebd56b476a2817c5a876ce4638254b7b4ac93175318fb59598ed5532f33433951d75afea03724ef4419c3e1bd12ca8c20","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1028277533\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/secp256k1/issues/990\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/secp256k1/pull/990/hovercard\" href=\"https://github.com/bitcoin-core/secp256k1/pull/990\">#990</a>: Add comment on length checks when parsing ECDSA sigs"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVNrvDwA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin-core/secp256k1"}