Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now playing image buttons are broken #171

Open
uzegonemad opened this issue Feb 29, 2024 · 1 comment · May be fixed by #178
Open

Now playing image buttons are broken #171

uzegonemad opened this issue Feb 29, 2024 · 1 comment · May be fixed by #178
Labels
bug Something isn't working

Comments

@uzegonemad
Copy link
Contributor

Describe the bug
Image buttons on the now playing template were broken in 2f26991

If you see here you will notice that the CPNowPlayingImageButton is no longer using initWithImage.

I have a patch that fixes this and will create a PR.

To Reproduce
Steps to reproduce the behavior:

  1. Add a now playing template with an image button
  2. No image displays on the button (a blank question mark symbol displays instead)

Expected behavior
An image to display.

CarPlay (please complete the following information):

  • RNCarPlay version 2.4.0-beta.2
@uzegonemad uzegonemad added the bug Something isn't working label Feb 29, 2024
@janwiebe-jump janwiebe-jump linked a pull request Apr 5, 2024 that will close this issue
Open
@limadouglas
Copy link

limadouglas commented Apr 17, 2024 •
edited

@uzegonemad It's worked for me: #6 (comment)

The image must have dimensions of 80x80 pixels and be named <something>@3.png.

exemplo:
arrow@3x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement image button in CarPlay CPNowPlayingTemplate. janwiebe-jump/react-native-carplay
2 participants
@uzegonemad @limadouglas