Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now playing image buttons are broken #171

Open
uzegonemad opened this issue Feb 29, 2024 · 3 comments · May be fixed by #178
Open

Now playing image buttons are broken #171

uzegonemad opened this issue Feb 29, 2024 · 3 comments · May be fixed by #178
Labels
bug Something isn't working

Comments

@uzegonemad
Copy link
Contributor

Describe the bug
Image buttons on the now playing template were broken in 2f26991

If you see here you will notice that the CPNowPlayingImageButton is no longer using initWithImage.

I have a patch that fixes this and will create a PR.

To Reproduce
Steps to reproduce the behavior:

  1. Add a now playing template with an image button
  2. No image displays on the button (a blank question mark symbol displays instead)

Expected behavior
An image to display.

CarPlay (please complete the following information):

  • RNCarPlay version 2.4.0-beta.2
@uzegonemad uzegonemad added the bug Something isn't working label Feb 29, 2024
@limadouglas
Copy link

limadouglas commented Apr 17, 2024

@uzegonemad It's worked for me: #6 (comment)

The image must have dimensions of 80x80 pixels and be named <something>@3.png.

exemplo:
arrow@3x

@syedslegend786
Copy link

Describe the bug Image buttons on the now playing template were broken in 2f26991

If you see here you will notice that the CPNowPlayingImageButton is no longer using initWithImage.

I have a patch that fixes this and will create a PR.

To Reproduce Steps to reproduce the behavior:

  1. Add a now playing template with an image button
  2. No image displays on the button (a blank question mark symbol displays instead)

Expected behavior An image to display.

CarPlay (please complete the following information):

  • RNCarPlay version 2.4.0-beta.2

Hi, I am also working on react native app, to work it with android-auto. If you can share your project implementation repo, it will help alot, because i am facing issues with NowplayingTemplate

@limadouglas
Copy link

limadouglas commented May 29, 2024

@syedslegend786 Sorry, I can't because it's a private project.
If you are having issues, I recommend that you join the React Native Carplay Discord server and ask for help: https://discord.gg/b235pv6QHM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants