Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axios upgrade to 1.x #264

Closed
birdofpreyru opened this issue Oct 6, 2022 · 4 comments
Closed

axios upgrade to 1.x #264

birdofpreyru opened this issue Oct 6, 2022 · 4 comments
Labels
P2 Important. Nice to have improvements and optimizations. Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release.

Comments

@birdofpreyru
Copy link
Owner

For now we keep axios@0.27.2, as the latest axios@1.0.0 breaks React-Natve applications (e.g. see axios/axios#4998), and also breaks some tests (see #263). Evaluate possibility of the upgrade when new axios versions arrive.
@birdofpreyru birdofpreyru added On Hold Blocked by another ticket / issue / etc. P2 Important. Nice to have improvements and optimizations. labels Oct 6, 2022
@birdofpreyru birdofpreyru mentioned this issue Oct 6, 2022
Open
@ahmadhendri21
Copy link

ahmadhendri21 commented Oct 6, 2022 •
edited

axios@1.0.0 bad for react native 0.70.~
ERROR : TypeError: Restricted in strict mode, js engine: hermes
any solution other than downgrade?

birdofpreyru added a commit that referenced this issue Nov 24, 2022
@birdofpreyru
[#264] Upgrade of axios to 1.x (1.2.0)
98db97a
@birdofpreyru birdofpreyru added Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release. and removed On Hold Blocked by another ticket / issue / etc. labels Nov 24, 2022
@birdofpreyru
Copy link
Owner Author

birdofpreyru commented Nov 24, 2022 •
edited

axios@1.2.0 turns out to have issues with response decording when gzip- (or perhaps also otherwise) compressed. See (axios/axios#5296), (axios/axios#5298). Thus, waiting the next v1.x release.

@birdofpreyru birdofpreyru reopened this Nov 24, 2022
@birdofpreyru birdofpreyru added On Hold Blocked by another ticket / issue / etc. and removed Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release. labels Nov 24, 2022
birdofpreyru added a commit that referenced this issue Nov 24, 2022
@birdofpreyru
[#264] v1.22.2: Downgrades axios to 0.27.2 + Updates other dependencies
e5ca139
@birdofpreyru birdofpreyru added In Progress Currently in works, but not clear, how many time it will get to complete. and removed On Hold Blocked by another ticket / issue / etc. labels Jan 8, 2023
@birdofpreyru
Copy link
Owner Author

birdofpreyru commented Jan 8, 2023 •
edited

Testing axios@1.2.2 for react-utils@1.22.3 release, let's see if it works.

NOTE: As of axios@1.2.2 there is HttpStatusCode export from the library, I believe, which is probably can/should be used to drop our dependency on http-status-codes library?

birdofpreyru added a commit that referenced this issue Jan 9, 2023
@birdofpreyru
[#264] v1.22.3: Updates dependencies
bb70f1e
@birdofpreyru birdofpreyru added Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release. and removed In Progress Currently in works, but not clear, how many time it will get to complete. labels Jan 18, 2023
@birdofpreyru
Copy link
Owner Author

It looks like axios@1.2.2 works fine everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important. Nice to have improvements and optimizations. Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@birdofpreyru @ahmadhendri21