New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iron out which minimum dependency versions, exactly, are needed #42
Comments
Altair
biom-format
click
pandas
pytest
scikit-bio
numpy
|
Requiring pytest but not flake8 makes sense -- tests passing is much more important than code style being 100% perfect (and that should be enforced by travis anyway) See #42 for additional context and future plans.
also, update readme when this is sorted out |
Yeah, so we do need numpy for a few things (in particular, the |
this seems to have sprung up out of nowhere (seriously, the commit that broke it updated .gitattributes and nothing else iirc). I also updated the pandas minimum version to match biom-format's requirements. don't expect that'll play any sort of role in fixing this issue but worth noting re: #42
I forgot to mention it in the message, but this is closed by commit fedarko@e94c09b. |
Current dependencies (for which this is a concern):
To get context about how each of these libraries are used within rankratioviz, you can navigate to the root directory of the repo and run
grep -ri "alt\." * -A 2
, wherealt
is just the name of the module as imported (e.g.skbio
for scikit-bio, orpd
for pandas). The -A option can be configured to show context after matching occurrences, which helps us figure out what not only what module functions are called but what arguments of these functions are used. This isn't a perfect overview of things -- e.g. if a "from [module] import [thing]" command is used this won't catch that, or if you declare an object of type [module.thing] then this won't show all the ways that object is used -- but it's a solid start.(also, note that that search command might fail if you somehow invoke a module on one line and then invoke its function on the next line -- is that even doable in python? -- but we're following flake8 on this project so i don't think that'll happen here)
The text was updated successfully, but these errors were encountered: